Draggable: A small iframeFix refinement #544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of body This gives the user a measure of control over where the fixes are added - one simply needs to specify "position: relative" on an ancestor of the iframe and the fix will be put there. In this way, the iframe fixes can be a little bit more robust when changes to the page happen which cause the iframes to change their offset on the page. Things will still break if the iframe changes size or moves within its offset parent.
|
Hi! Is there anything I can do to get this looked at? Would filing a bug report help? |
|
Hi @atrigent, please add some unit tests to your pull requests. This will help get your pull looked at and considered for inclusion in the library. Thanks! |
|
Hi @atrigent, I'm cleaning up the pull request queue right now. Considering this pull request is 11 months old, and doesn't have a ticket that demonstrates the problem, nor unit tests, I'm going to close this for now to keep the queue clean. I really appreciate the work you've done here, and if you'd still like to pursue this, please file a ticket in the tracker showing the problem, and make sure you run the current test suite, and add new tests that support this change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an application which has a draggable which adds its droppables in its "start" function. This causes some churn throughout the page and causes the iframes to change their position relative to the "body" tag, which in turn means that the iframe fixes which had been previously added are no longer in the right place. With this change, the user can configure things so that the iframe fixes follow their respective iframes around wherever they move. It fixes the issue I'm encountering with this application, and will result in the same behavior as before if there is no other offset parent than body.
Thanks!
Ari