New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #4857 - Nested lists don't work properly with sortable. #555

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
@rtwo

rtwo commented Dec 20, 2011

Fixes: #4857 - Nested lists don't work properly with sortable.

This commit, as tiny as it may be, makes nested-sortables actually usable.

Martin Hoch hoch@fidion.de added some commits Dec 20, 2011

Martin Hoch hoch@fidion.de
Sortable: fixed jerkiness with nested-sortables.
Fixes: #4857 - Nested lists don't work properly with sortable.
@rtwo

This comment has been minimized.

Show comment
Hide comment
@rtwo

rtwo Jan 2, 2012

I also Fixed #5159. Am I really the only one who uses nested-sortables? :-)

rtwo commented Jan 2, 2012

I also Fixed #5159. Am I really the only one who uses nested-sortables? :-)

@johnny

This comment has been minimized.

Show comment
Hide comment
@johnny

johnny Feb 3, 2012

+1 for this pull request

johnny commented Feb 3, 2012

+1 for this pull request

@loopforever

This comment has been minimized.

Show comment
Hide comment
@loopforever

loopforever Feb 21, 2012

+1 for this request as well. Actually makes nested sortables work.

loopforever commented Feb 21, 2012

+1 for this request as well. Actually makes nested sortables work.

@burkeholland

This comment has been minimized.

Show comment
Hide comment
@burkeholland

burkeholland Feb 23, 2012

SRSLY? Maintenance release 1.8.18 is out and I still don't see this fix. Did I miss it?

burkeholland commented Feb 23, 2012

SRSLY? Maintenance release 1.8.18 is out and I still don't see this fix. Did I miss it?

@jeffchao

This comment has been minimized.

Show comment
Hide comment
@jeffchao

jeffchao Feb 23, 2012

+1 for pull request. Nested sortables problem is very real. This helps.

jeffchao commented Feb 23, 2012

+1 for pull request. Nested sortables problem is very real. This helps.

@adamstrawson

This comment has been minimized.

Show comment
Hide comment
@adamstrawson

adamstrawson Mar 16, 2012

+1 for pull this pull request.

adamstrawson commented Mar 16, 2012

+1 for pull this pull request.

@hetsch

This comment has been minimized.

Show comment
Hide comment
@hetsch

hetsch Mar 26, 2012

+1 for pull request. Helps a lot!

hetsch commented Mar 26, 2012

+1 for pull request. Helps a lot!

@burkeholland

This comment has been minimized.

Show comment
Hide comment
@burkeholland

burkeholland Mar 26, 2012

Any update on this? I know many of us are working with a modified version of the library to support this. We would love to see it be official so that others looking for the functionality don't have to find it the hard way.

burkeholland commented Mar 26, 2012

Any update on this? I know many of us are working with a modified version of the library to support this. We would love to see it be official so that others looking for the functionality don't have to find it the hard way.

@real-didi

This comment has been minimized.

Show comment
Hide comment
@real-didi

real-didi Mar 30, 2012

+1 for pull request. It solved the problem and helped a lot.
To make it fully work for me:

  • a sortable for each nested list
  • removed option 'toleranceElement' since no need in it with this fix

real-didi commented Mar 30, 2012

+1 for pull request. It solved the problem and helped a lot.
To make it fully work for me:

  • a sortable for each nested list
  • removed option 'toleranceElement' since no need in it with this fix
@joeellis

This comment has been minimized.

Show comment
Hide comment
@joeellis

joeellis Mar 30, 2012

Also wondering on the status of this PR

joeellis commented Mar 30, 2012

Also wondering on the status of this PR

@me

This comment has been minimized.

Show comment
Hide comment
@me

me Apr 5, 2012

Wow, this actually works! Nested lists are usable at last! Thanks. +1

me commented Apr 5, 2012

Wow, this actually works! Nested lists are usable at last! Thanks. +1

@codeincontext

This comment has been minimized.

Show comment
Hide comment
@codeincontext

codeincontext Apr 11, 2012

+1 Wish I discovered this earlier

codeincontext commented Apr 11, 2012

+1 Wish I discovered this earlier

@Jellyfrog

This comment has been minimized.

Show comment
Hide comment
@Jellyfrog

Jellyfrog commented Apr 17, 2012

+1

1 similar comment
@Fauntleroy

This comment has been minimized.

Show comment
Hide comment
@Fauntleroy

Fauntleroy commented Aug 15, 2012

+1

@Carenthir

This comment has been minimized.

Show comment
Hide comment
@Carenthir

Carenthir Aug 21, 2012

+1 , this is brilliant.
Thanks Martin, this is weird the UI guys haven't merged the fix yet.

Carenthir commented Aug 21, 2012

+1 , this is brilliant.
Thanks Martin, this is weird the UI guys haven't merged the fix yet.

@terracatta

This comment has been minimized.

Show comment
Hide comment
@terracatta

terracatta Aug 22, 2012

+1
Can we get this merged in please? Or a least a reason why a merge isn't possible?

terracatta commented Aug 22, 2012

+1
Can we get this merged in please? Or a least a reason why a merge isn't possible?

@gnarf

This comment has been minimized.

Show comment
Hide comment
@gnarf

gnarf Aug 22, 2012

Member

Sorry this one has sat around for so long, there have obviously been some people testing and supporting it. This widget still hasn't been re-written yet which is why we have taken our time landing any updates to it.

What would definitely help is if you could provide a unit test for this functionality, so that we can ensure we continue to support this after the rewrite, and won't regress.

We plan on trying to land this before the 1.9 Release.

Member

gnarf commented Aug 22, 2012

Sorry this one has sat around for so long, there have obviously been some people testing and supporting it. This widget still hasn't been re-written yet which is why we have taken our time landing any updates to it.

What would definitely help is if you could provide a unit test for this functionality, so that we can ensure we continue to support this after the rewrite, and won't regress.

We plan on trying to land this before the 1.9 Release.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Aug 23, 2012

Member

Thanks, this has finally landed in master: 2b899cc and b9ef00f.

Member

scottgonzalez commented Aug 23, 2012

Thanks, this has finally landed in master: 2b899cc and b9ef00f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment