Theme: Give option to not support legacy browsers with invalid CSS (for master branch) #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me whitespace issues
Using the following coding standard makes the CSS much more readable and easier to handle (e.g. copying and pasting or commenting rules) and also makes it easier to identify the differences between commits:
selector,
selector {
property: value;
property: value;
}
Used cleaner alternatives for .ui-helper-hidden-accessible and .ui-helper-clearfix and moved .ui-helper-zfix over to a new css file (jquery.ui.ancient.css) to separate IE6-only fixes from the rest to make it easier to remove them.
The font-family and font-size should always be automatically inherited from each site's styles. There's no need to include them, except for demo/previewing purposes.
* moved .ui-datepicker-cover to IE6-only styles * moved opacity filters for .ui-priority-secondary, .ui-state-disabled and .ui-widget-shadow to new css file for non-latest browsers (jquery.ui.legacy.css) as they enhance the usability but are not essential * only left opacity filter for .ui-widget-overlay as removing this would make the overlay unusable in IEs<9
* moved all occurrences of zoom to the IE6-only styles * except one style was also for IE7: changed '.ui-menu .ui-menu-item a' to use min-height instead * moved workaround for .ui-autocomplete to IE6-only styles * moved star hack for .ui-button to non-latest styles and changed invalid hack into valid hack
…dow to non-latest styles As border-radius and box-shadow are supported by all latest browsers, their vendor-specific prefixed equivalents are not very important anymore.
This is the only other invalid CSS left as it helps to keep button styling a bit more consistent. But it's still debatable as every button looks different in every browser anyway.
Removed border colour from .ui-selectable-helper as the colour will automatically be the inherited text colour.
* added font-size back to .ui-widget form elements (just in case) * added font-size to .ui-widget itself to avoid problems when it's attached to form elements themselves
The general (.ui-widget) font-size shouldn't be part of the core CSS (so, removed in a3b2ad3), but should be set if needed by the user. As the demos set a body font-size of 62.5%, the original 1.1em make sense in there.
|
+1. I'd like to see this implemented and have my CSS valid again. |
|
+1 I like it |
|
This can't be merged anymore: IE6 fixes got removed for 1.10, and with all the formatting changes its impossible to figure out what is still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://bugs.jqueryui.com/ticket/7975