Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Theme: Give option to not support legacy browsers with invalid CSS (for master branch) #558

Closed
wants to merge 12 commits into from

4 participants

Anika Henke Andreas Gohr Jellyfrog Jörn Zaefferer
selfthinker added some commits
Anika Henke selfthinker CSS cleanup: changed coding standard to be more readable and fixed so…
…me whitespace issues

Using the following coding standard makes the CSS much more readable and easier to handle (e.g. copying and pasting or commenting rules) and also makes it easier to identify the differences between commits:

selector,
selector {
    property: value;
    property: value;
}
cfea325
Anika Henke selfthinker CSS cleanup: removed invalid CSS from core styles
Used cleaner alternatives for .ui-helper-hidden-accessible and .ui-helper-clearfix and moved .ui-helper-zfix over to a new css file (jquery.ui.ancient.css) to separate IE6-only fixes from the rest to make it easier to remove them.
24de1b9
Anika Henke selfthinker CSS cleanup: deleted font-family and font-size from theme styles
The font-family and font-size should always be automatically inherited from each site's styles. There's no need to include them, except for demo/previewing purposes.
a3b2ad3
Anika Henke selfthinker CSS cleanup: moved most IE filters
* moved .ui-datepicker-cover to IE6-only styles
* moved opacity filters for .ui-priority-secondary, .ui-state-disabled and .ui-widget-shadow to new css file for non-latest browsers (jquery.ui.legacy.css) as they enhance the usability but are not essential
* only left opacity filter for .ui-widget-overlay as removing this would make the overlay unusable in IEs<9
0060a7a
Anika Henke selfthinker CSS cleanup: (re)moved some IE-specific hacks
* moved all occurrences of zoom to the IE6-only styles
* except one style was also for IE7: changed '.ui-menu .ui-menu-item a' to use min-height instead
* moved workaround for .ui-autocomplete to IE6-only styles
* moved star hack for .ui-button to non-latest styles and changed invalid hack into valid hack
1d1a078
Anika Henke selfthinker CSS cleanup: moved vendor-specific prefixed border-radius and box-sha…
…dow to non-latest styles

As border-radius and box-shadow are supported by all latest browsers, their vendor-specific prefixed equivalents are not very important anymore.
d27b874
Anika Henke selfthinker CSS cleanup: added input as another candidate for ::-moz-focus-inner
This is the only other invalid CSS left as it helps to keep button styling a bit more consistent. But it's still debatable as every button looks different in every browser anyway.
0ef8fe9
Anika Henke selfthinker CSS cleanup: removed some redundant lines a4f232f
Anika Henke selfthinker CSS cleanup: removed redundant colour
Removed border colour from .ui-selectable-helper as the colour will automatically be the inherited text colour.
b578d84
Anika Henke selfthinker CSS cleanup: split IE6+7 button fix up into 2 different files a8594c3
Anika Henke selfthinker CSS cleanup: small font-size changes
* added font-size back to .ui-widget form elements (just in case)
* added font-size to .ui-widget itself to avoid problems when it's attached to form elements themselves
22b52d6
Anika Henke selfthinker CSS cleanup: added bigger font-size to .ui-widget in demos
The general (.ui-widget) font-size shouldn't be part of the core CSS (so, removed in a3b2ad3), but should be set if needed by the user. As the demos set a body font-size of 62.5%, the original 1.1em make sense in there.
81195ab
Andreas Gohr

+1. I'd like to see this implemented and have my CSS valid again.

Jellyfrog

+1 I like it

Jörn Zaefferer
Owner

This can't be merged anymore: IE6 fixes got removed for 1.10, and with all the formatting changes its impossible to figure out what is still valid.

Jörn Zaefferer jzaefferer closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 28, 2011
  1. Anika Henke

    CSS cleanup: changed coding standard to be more readable and fixed so…

    selfthinker authored
    …me whitespace issues
    
    Using the following coding standard makes the CSS much more readable and easier to handle (e.g. copying and pasting or commenting rules) and also makes it easier to identify the differences between commits:
    
    selector,
    selector {
        property: value;
        property: value;
    }
  2. Anika Henke

    CSS cleanup: removed invalid CSS from core styles

    selfthinker authored
    Used cleaner alternatives for .ui-helper-hidden-accessible and .ui-helper-clearfix and moved .ui-helper-zfix over to a new css file (jquery.ui.ancient.css) to separate IE6-only fixes from the rest to make it easier to remove them.
  3. Anika Henke

    CSS cleanup: deleted font-family and font-size from theme styles

    selfthinker authored
    The font-family and font-size should always be automatically inherited from each site's styles. There's no need to include them, except for demo/previewing purposes.
  4. Anika Henke

    CSS cleanup: moved most IE filters

    selfthinker authored
    * moved .ui-datepicker-cover to IE6-only styles
    * moved opacity filters for .ui-priority-secondary, .ui-state-disabled and .ui-widget-shadow to new css file for non-latest browsers (jquery.ui.legacy.css) as they enhance the usability but are not essential
    * only left opacity filter for .ui-widget-overlay as removing this would make the overlay unusable in IEs<9
Commits on Dec 29, 2011
  1. Anika Henke

    CSS cleanup: (re)moved some IE-specific hacks

    selfthinker authored
    * moved all occurrences of zoom to the IE6-only styles
    * except one style was also for IE7: changed '.ui-menu .ui-menu-item a' to use min-height instead
    * moved workaround for .ui-autocomplete to IE6-only styles
    * moved star hack for .ui-button to non-latest styles and changed invalid hack into valid hack
  2. Anika Henke

    CSS cleanup: moved vendor-specific prefixed border-radius and box-sha…

    selfthinker authored
    …dow to non-latest styles
    
    As border-radius and box-shadow are supported by all latest browsers, their vendor-specific prefixed equivalents are not very important anymore.
  3. Anika Henke

    CSS cleanup: added input as another candidate for ::-moz-focus-inner

    selfthinker authored
    This is the only other invalid CSS left as it helps to keep button styling a bit more consistent. But it's still debatable as every button looks different in every browser anyway.
  4. Anika Henke
  5. Anika Henke

    CSS cleanup: removed redundant colour

    selfthinker authored
    Removed border colour from .ui-selectable-helper as the colour will automatically be the inherited text colour.
  6. Anika Henke
  7. Anika Henke

    CSS cleanup: small font-size changes

    selfthinker authored
    * added font-size back to .ui-widget form elements (just in case)
    * added font-size to .ui-widget itself to avoid problems when it's attached to form elements themselves
  8. Anika Henke

    CSS cleanup: added bigger font-size to .ui-widget in demos

    selfthinker authored
    The general (.ui-widget) font-size shouldn't be part of the core CSS (so, removed in a3b2ad3), but should be set if needed by the user. As the demos set a body font-size of 62.5%, the original 1.1em make sense in there.
Something went wrong with that request. Please try again.