Skip to content

fix for #6643 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix for #6643 #62

wants to merge 1 commit into from

Conversation

poplix
Copy link
Contributor

@poplix poplix commented Dec 3, 2010

hi,
I changed _trimAlignValue function to return the correct inclusive value between min and max..

@poplix
Changed _trimAlignValue function to return the correct inclusive valu…
9ab1c10 
…e between min and max.Fixes #6643 - using range and step options makes jquery change min and max
@scottgonzalez
Copy link
Member

This doesn't fix the problem, all it does is allow you to hit the min and max exactly. Every other possible step is still wrong.

@poplix
Copy link
Contributor Author

poplix commented Dec 3, 2010

of course you're right.. forgive my impatience..
valModStep = (val - this._valueMin()) % step; instead of valModStep = val % step; should fix the problem..

@scottgonzalez
Copy link
Member

Thank, landed in 0d0969c.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poplix @scottgonzalez