Skip to content

Resizable: fixed destroy so that it doesn't remove all sub (find) elem... #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

christurnertv
Copy link

...ents with a class of ui-resizable-handle, but only children with that class from a target element. Fixed #8344 - Resizable: Destroy function removing ui-resizable-handle from inner containers

…lements with a class of ui-resizable-handle, but only children with that class from a target element. Fixed #8344 - Resizable: Destroy function removing ui-resizable-handle from inner containers
@scottgonzalez
Copy link
Member

There are lots of other references to handles using .find(); this isn't an adequate fix. At a minimum, it needs to support custom handles, which can currently be at any level.

@christurnertv
Copy link
Author

With the current implementation, it appears that custom handles can be anywhere within the resizable container, but not outside. Is this correct? Do you think it would be a bad thing to require that custom handles be a child of the resizable container?

@scottgonzalez
Copy link
Member

Bad? No. Breaking change? Yes.

@christurnertv
Copy link
Author

Fair enough. It does seems like any change that will allow nested resizable containers to work as expected (in regard to this issue) will break the current "you can have custom resize handles at any level below the parent resizable container". Even if you introduced custom names and classes for the handles that again would be a new requirement and breaking change. I'm new to this, how do you all handle such things?

@scottgonzalez
Copy link
Member

We wait until a major release to introduce the change. However, since resizable is being rewritten, we're not allowing any API changes.

@christurnertv
Copy link
Author

Ok, thanks for your time and the info Scott.

@dekajp
Copy link
Contributor

dekajp commented Nov 16, 2013

@scottgonzalez - since resizable is being rewritten finish ?

@scottgonzalez
Copy link
Member

@dekajp I don't understand the question.

@dekajp
Copy link
Contributor

dekajp commented Nov 16, 2013

@scottgonzalez are we done with rewritting or is it in progress ?

@scottgonzalez
Copy link
Member

The interaction rewrite is in progress. See the interactions branch(es).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants