Fixed: #8531 Shake effect: Duration is multiplied based on number of shakes #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shakes I changed the speed generation to Math.round(o.duration/times) to ensure that the given amount of time is the time the animation takes to complete.
| @@ -22,7 +22,7 @@ $.effects.effect.shake = function( o, done ) { | |||
| distance = o.distance || 20, | |||
| times = o.times || 3, | |||
| anims = times * 2 + 1, | |||
| speed = o.duration, | |||
| speed = Math.round(o.duration/times), | |||
There was a problem hiding this comment.
That should be divided by anims, not times.
Changed to anims
|
Thanks, landed in dec9c54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the speed generation to Math.round(o.duration/times) to ensure that the given amount of time is the time the animation takes to complete.