Skip to content

Use toggleClass instead of [ bool ? "addClass" : "removeClass" ] #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use toggleClass instead of [ bool ? "addClass" : "removeClass" ] #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/jquery.ui.accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,7 @@ $.widget( "ui.accordion", {
// so we need to add the disabled class to the headers and panels
if ( key == "disabled" ) {
this.headers.add(this.headers.next())
[ value ? "addClass" : "removeClass" ](
"ui-accordion-disabled ui-state-disabled" );
.toggleClass( "ui-accordion-disabled ui-state-disabled", !!value );
}
},

Expand Down
3 changes: 1 addition & 2 deletions ui/jquery.ui.sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ $.widget("ui.sortable", $.ui.mouse, {
if ( key === "disabled" ) {
this.options[ key ] = value;

this.widget()
[ value ? "addClass" : "removeClass"]( "ui-sortable-disabled" );
this.widget().toggleClass( "ui-sortable-disabled", !!value );
} else {
// Don't call widget base _setOption for disable as it adds ui-state-disabled class
$.Widget.prototype._setOption.apply(this, arguments);
Expand Down
9 changes: 3 additions & 6 deletions ui/jquery.ui.tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,7 @@ $.widget( "ui.tabs", {
o.selected = this.lis.index( this.lis.filter( ".ui-tabs-selected" ) );
}

// update collapsible
// TODO: use .toggleClass()
this.element[ o.collapsible ? "addClass" : "removeClass" ]( "ui-tabs-collapsible" );
this.element.toggleClass( "ui-tabs-collapsible", o.collapsible );

// set or update cookie after init and add/remove respectively
if ( o.cookie ) {
Expand All @@ -244,9 +242,8 @@ $.widget( "ui.tabs", {

// disable tabs
for ( var i = 0, li; ( li = this.lis[ i ] ); i++ ) {
$( li )[ $.inArray( i, o.disabled ) != -1 &&
// TODO: use .toggleClass()
!$( li ).hasClass( "ui-tabs-selected" ) ? "addClass" : "removeClass" ]( "ui-state-disabled" );
$( li ).toggleClass( "ui-state-disabled",
$.inArray( i, o.disabled ) != -1 && !$( li ).hasClass( "ui-tabs-selected" ) );
}

// reset cache if switching from cached to not cached
Expand Down
4 changes: 1 addition & 3 deletions ui/jquery.ui.widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,7 @@ $.Widget.prototype = {

if ( key === "disabled" ) {
this.widget()
[ value ? "addClass" : "removeClass"](
this.widgetBaseClass + "-disabled" + " " +
"ui-state-disabled" )
.toggleClass( this.widgetBaseClass + "-disabled" + " " + "ui-state-disabled", !!value )
.attr( "aria-disabled", value );
}

Expand Down