No description provided.
Effect: check if option parameter is an object. Fixed #8670 - null re…
…ference when using effects
Thanks for contributing! Can you add a unit test for this as well?
I've never done that before:/ Can You guide me, tell me where to start, how unit test should looks like? What should i check within it? Thanks for any help.
options == null is better than adding the call to isPlainObject here.
options == null
Effects: Allow 'null' for options - Fixes #8670 - null reference when…
… using effects - Closes gh-783
Thanks for forcing my hand on this one, I was planning on the == null check anyway.
P.S. my commit also included a unit test so you can check out how you go about writing one of those.
Thanks for this unit test. I will learn to write those for better contributing :) Please correct me if i am wrong. Is options == null the same as options == undefined?
options == undefined
options == null will only be true for null and undefined - It is the only case we use == inside jQuery code for exactly this reason.