Resizable handle complex markup #810
Conversation
…ble to the draggable testsuite.
| @@ -145,4 +145,24 @@ test("nw", function() { | |||
| equal( target.height(), 100, "compare height" ); | |||
| }); | |||
|
|
|||
| test("handle with complex markup (#8756)", function() { | |||
There was a problem hiding this comment.
this test should be removed in favor of the other test.
There was a problem hiding this comment.
Hmm.. so, to sum up, you two want the resizable complex markup handle test to be a single test that is located in the draggable testsuite? Seems strange to me. Have I missinterpreted?
There was a problem hiding this comment.
Nevermind, you're right. It just seemed like this test was redundant given the other test, but it can't hurt. Have you also considered one test with reversing the calls to draggable() and sortable()?
There was a problem hiding this comment.
Yeah, this is correct. The resizable test is checking for support of complex markup and the draggable test is checking that resizing is possible while draggable is enabled.
There was a problem hiding this comment.
Do you mean draggable() vs resizable() (not sortable?)
No, I have not tried that. Now that you mention it, is it because the ui.mouse thing will call the capture methods in another order depending on the order the widgets are initialized? I havnt considered that before...
There was a problem hiding this comment.
Sorry, I meant that last comment for the lines above... look up.
|
@MatteS75, I think we're good to go once you make those changes. You'll need to rebase as well considering this can't be automatically merged. Thanks again! |
…ngle resizable test in the draggable testsuite
|
Made that change, now I have to read up on rebasing ;) |
|
Rebasing involves checking out master, pulling down the latest changes from upstream, checking out your branch, and then saying |
… test suite to pass
…tion - Fixed #8770 Dev: Remove globals and Standardize Test Suite
…ve globals and Standardize Test Suite
… #5659 - CSS Framework: Don't show icon when only ui-icon class is present.
…Menu: refresh() doesn't refresh existing submenus.
…rammatically moving focus to track-toolipped-input. Fixes #8747 - Tooltip: Using the track option within dialogs creates JS errors
…ip ever overlapping the trigger. Also fix max-width for custom-content demo. Fixes #8739 - Tooltip: Default positioning on large items off.
…Safari 5.1 when window.location contains a space.
…bug in core. Fixes #8741 - Dialog: dialog with position:fixed goes offscreen when opening after scrolling down since v 1.9.0.
This reverts commit 4995ea0.
…tribute is not removed from tabs when destroy is called.
…- Dev: re-enable the dialog test suite
… - Dev: re-enable the datepicker test suite
… widget. Fixes #8805 - Widget: widgetEventPrefix is incorrect when inheriting with jQuery UI 1.9.1.
…on doesn't remove hover state if they are disabled
…72 - Accordion: ability to add/remove panels
…idth and height when only one is changing Resizable: Trigger resize event only when element is resized. Fixes #5545 - Callbacks ignore the grid. Resizable: Added event tests. Fixes #5817 - resize event reports unconstrained ui.size
…arRange. Fixes #7362 - Datepicker allows changing year to something outside yearRange
… not hide consistently with dynamically loaded content.
…s while open (we no longer mix events). Fixes #8799 - Tooltip: tracking fails on nested elements.
…r: Faroese locale has incorrect firstDay.
…ble to the draggable testsuite.
…ngle resizable test in the draggable testsuite
|
@MatteS75, looks like you're having a bit of trouble with the rebasing. Perhaps open a new pull request? |
|
yes, I will. I dont understand why, but the windows github tool started moving all the commits into my branch, and that most certainly was not intentional! Ill have to sort this out, and create a new RP. It can take a while... |
|
Do you want this still to be its own branch, or, as I understand it, rebase to master and create a new RP from my master? |
|
Still a branch! |
|
Phew, man this is getting messy! Created a new PR, hope I didnt mess up too much... |
Here's the updated PR for http://bugs.jqueryui.com/ticket/8756