typesetting on dialog title bar was inconsistent with other widget title bars/headers #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was there a reason the title was set low on the titlebar of dialog? The numbers don't lie: .ui-dialog-titlebar has uneven vertical padding and the inner span has uneven vertical margin (by .1em?). Verified this with the demo site in Safari 5 osx, FF 3.6 win/osx, Chrome and IE6. Originally I thought this must have been a leftover IE6 hack but IE6 actually displays the margin/padding correctly (poorly). The vertical typesetting on all the other widgets appears fine so this one really stands out. If I need to provide you with frame grabs from each of these browsers or make a diagram comparing the other widgets...