Skip to content

Conversation

alexeevdv
Copy link

You can see example here: http://jsfiddle.net/alexeevdv/9C9Ak/

@scottgonzalez
Copy link
Member

We'd like to hold off on this for now and see how popular it is as an extension first. For examples of extensions, see https://github.com/scottgonzalez/jquery-ui-extensions or the back-compat in 1.9.x tabs for newer syntax:

// DEPRECATED

I do have a few recommendations though. Remove .ui-dialog-titlebar-icon-spacer and instead conditionally add padding to the title text (see accordion for an example). Don't check the type of the icon option, since there's only one valid type (and all falsey values should be treated the same). If the icon option starts with a value and is then removed, you need to handle that state properly. Finally, you might consider an icons hash for consistency, even if there's only one icon.

Thanks for your contribution, hopefully another patch of yours will make it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants