Slider: Explicitly apply opacity filter to disabled handles. Fixed #6727...

[tjvantoll]

... - Slider: Visual issues with disabled slider in IE8

See http://bugs.jqueryui.com/ticket/6727.

[mikesherov]

@tjvantoll, are there any unit tests you can write for this, or is this visual only?

[tjvantoll]

Visual only. I could write a test that checks the computed style after the fix is applied but I would have to browser sniff in the test to make it work.

I could put something in the /tests/visual folder but I'm not sure that's maintained anymore.

[mikesherov]

@tjvantoll, can you rebase this since we landed a large CSS coding style change. Thanks man!

[tjvantoll]

@mikesherov I merged master back in to my branch.

[mikesherov]

@tjvantoll, so now there's a visual difference for IE8. The handles have some of there own opacity so you can see the sliders underneath. Certainly it's a lot better than appearing enabled, but @scottgonzalez, @jzaefferer, is this acceptable?

[scottgonzalez]

I think ti's fine unless we have a sane solution to get it to look the same as other browsers.

Shitty browsers = worse results. It's the world we live in :-/

[mikesherov]

OK, so one last thing to discuss here... It's amazing how the "simplest" changes are hard to land. CSSLint is complaining that .ui-slider.ui-state-disabled .ui-slider-handle violates the adjoining_classes csslint rule, because IE6 doesn't support adjoining classes.

We have two choices:

1. override that csslint option to false, considering the fix is IE8 only, and we no longer support IE6, and adjoining classes only fail in IE6.
2. change the css rule from .ui-slider.ui-state-disabled .ui-slider-handle to .ui-state-disabled .ui-slider-handle

@scottgonzalez @tjvantoll thoughts?

[jzaefferer]

Let's change the CSSLint rule.

[mikesherov]

Thanks, landed in 421aeaa

[tjvantoll]

@mikesherov Sorry for the late response but I agree with @jzaefferer, the CSSLint rule is no longer relevant to jQuery UI since we're dropping IE6 in 1.10. I also like the explicitness of including .ui-slider in this rule.

[mikesherov]

No worries @tjvantoll!