Skip to content

Conversation

schettino72
Copy link

...tepicker: Focus not placed back into textbox after date selection

… Datepicker: Focus not placed back into textbox after date selection
@mikesherov
Copy link
Member

Thanks for contributing! Can you provide a unit test for this fix? Also can you please sign our CLA: http://jquery.github.com/cla.html

@tjvantoll
Copy link
Member

It looks like the check being removed is a fix for an IE bug. See #7623 and bb79b41.

@mikesherov
Copy link
Member

@tjvantoll, another fix with no tests :/. Perhaps, someone could write a test for 7623, and then a test for this?

@schettino72
Copy link
Author

@mikesherov , actually i was not even able to run the tests. Can you please point me to some docs how to setup and run the tests? I already signed the CLA.

@tjvantoll , true I didnt test on IE. The bug description mentions this is a problem on all browsers.
On FF, the problem of #7623 happens if you set the focus before hiding the datepicker. Note how I inverted the order... unfortunately I have no access to IE to test it myself.

@tjvantoll
Copy link
Member

@schettino72 To run the tests you can open the main datepicker test file in a browser.

I tried this out and it indeed fixes #7765 but it also reintroduces #7623 in IE 7 - 10.

@schettino72
Copy link
Author

@tjvantoll sorry I have no access to widnows/IE maybe after a few days I can get a machine to test it...

@mikesherov
Copy link
Member

Thanks again for contributing, @schettino72! We're going to close this pull request for the time being until it can be properly tested in IE and we can be assured it doesn't cause a regression for http://bugs.jqueryui.com/ticket/7623 as @tjvantoll mentions. Please let us know when you have time to make progress on this.

Thanks again!

@mikesherov mikesherov closed this Apr 14, 2013
@kratos2333
Copy link

Any update on this one regarding the working version on IE 7-10 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants