Skip to content

Slider: moved events to named functions #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Slider: moved events to named functions #882

wants to merge 1 commit into from

Conversation

dominicbarnes
Copy link
Contributor

Originally, I created an issue for the Widget Factory not allowing events with namespaces, but the better solution was to move the event handlers for the slider into named functions so plugins/extensions to base widgets can hook in and not conflict with bound event handlers.

@scottgonzalez
Copy link
Member

Landed in 176e0ed.

I updated your email address in the git commit info to match the address you used when you signed the CLA. In the future, it would help if you could either use the other address or sign the CLA again with the email address you intend to use for contributions.

Thanks.

@dominicbarnes
Copy link
Contributor Author

@scottgonzalez I went ahead and signed the CLA again using my work email (dbarnes@treetopllc.com, since that is the one my github account is tied to, and the one all my commits are logged under)

@scottgonzalez
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants