Effects Core: make removeClass work correctly with changes jQuery 1.9.0.... #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -852,7 +852,7 @@ $.fn.extend({ | |||
| return speed ? | |||
| $.effects.animateClass.call( this, | |||
| { remove: classNames }, speed, easing, callback ) : | |||
| this._removeClass( classNames ); | |||
| classNames ? this._removeClass( classNames ) : this._removeClass(); | |||
There was a problem hiding this comment.
how about this for the entire body... not as clear?:
return arguments.length > 1 ?
$.effects.animateClass.call( this,
{ remove: classNames }, speed, easing, callback ) :
this._removeClass.apply( this, arguments );
There was a problem hiding this comment.
I am good either way. Will one uglify and gzip better?
There was a problem hiding this comment.
Probably wont make much difference.
There was a problem hiding this comment.
Let's go with my approach. One less conditional, and more future proof.
….0. Fixed #9015 - Inclusion of jQuery UI breaks removeClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Fixed #9015 - Inclusion of jQuery UI breaks removeClass