Autocomplete: don't prevent keypress for multiline (Firefox) #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 7, 2012 11:15
… Fixed #8301 - Placeholder doesn't move when using connectWith option
…d lists. Fixed #8301 - Placeholder doesn't move when using connectWith option" This reverts commit 96d5f18.
…ocomplete: Unable to use up/down arrow keys in a textarea (Firefox)
| @@ -142,7 +142,9 @@ $.widget( "ui.autocomplete", { | |||
| keypress: function( event ) { | |||
| if ( suppressKeyPress ) { | |||
| suppressKeyPress = false; | |||
| event.preventDefault(); | |||
| if ( !this.isMultiLine || this.menu.element.is( ":visible" ) ) { | |||
There was a problem hiding this comment.
Why is the visibility check necessary here?
There was a problem hiding this comment.
So when it's multiline (textarea), we only want to preventDefault when the autocomplete menu is visible. Otherwise, we can't use up/down arrows in the textarea in Firefox when the autocomplete menu is hidden (normal textarea keyboard navigation).
There was a problem hiding this comment.
Right, I think I'm getting confused because I'm not seeing a difference if we remove the visibility check. The logic makes sense, and I'm sure if I spent enough time I'd find something that would break without it. So I'm just going to land this :-)
|
Thanks, landed in f5f0879. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8911 - autocomplete: Unable to use up/down arrow keys in a textarea (Firefox)