Button: On form reset only call refresh on current button widgets. Fixed... #952

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Member

tjvantoll commented Apr 7, 2013

... #9213: Button: timeout in formResetHandler causing refresh to be called on non-widgets

Button: On form reset only call refresh on current button widgets. Fi…
…xed #9213: Button: timeout in formResetHandler causing refresh to be called on non-widgets
+ button = form.find( "button" ).button(),
+ checkbox = form.find( "input[type=checkbox]" ).button();
+
+ checkbox.prop( "checked", false ).button( "refresh" );
@scottgonzalez

scottgonzalez Apr 9, 2013

Owner

Add an assertion that it's not active after this refresh, before the reset.

Owner

scottgonzalez commented Apr 9, 2013

Fix looks good. The test could use an extra assertion to verify that a change is actually occurring.

Member

tjvantoll commented Apr 10, 2013

Added assertion. Landed in 2de31fd.

@tjvantoll tjvantoll closed this Apr 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment