Droppable event ordering issue #968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We'll need you to sign our CLA before we can review this pull request. |
|
@wesleycho, thanks again for contributing! now that you've signed our CLA, can you clean up your patch to conform to our style guide: http://contribute.jquery.org/style-guide/js/ I know a lot of the surrounding code doesn't conform, but all new code should. Also, we'll need a unit test with this pull request proving this fixes the bug. Can you add one |
|
I wrote up unit tests and made changes to conform to the style guide. |
|
@scottgonzalez, this looks right to me. Can you verify? |
| $( "<div id='draggable2'></div>" ).appendTo( "body" ); | ||
| var droppable3 = $( "#droppable3" ), | ||
| droppable4 = $( "#droppable4" ), | ||
| draggable2 = $( "#draggable2" ); |
There was a problem hiding this comment.
Why not just store the references as we create the elements? They don't even need IDs then.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #9258. Previously, when two droppable elements were nested and an item was dropped on the child (with "greedy" disabled), the order in which the callbacks were called was determined only by the order in which they were bound. This PR changes it so that deeper droppable elements always have their callbacks called first.