Give puff-effect and size-effect its own files. Previously, into scale-effect file. #981
Conversation
|
@mikesherov can you help me by double checking if there's really nothing to do on the unit tests side? As far as I saw, the scale-test tests scale only (not puff or size explicitly). |
|
Thanks @rxaviers. This seems right to me. I created a ticket for this; we'll need to update the commit message to reference it. This is probably a good time to add unit tests. @gnarf37 @mikesherov Can you do a review of this as well? Splitting files always seems like something that should get lots of eyes :-) |
|
I checked out the branch and ran tests/unit/effects/effects.html - it got stuck while running At least all effects are covered with the generated tests in |
|
effects_core fixed. Now, |
| if ( effect !== "puff" && effect !== "size" ) { | ||
| TestHelpers.testJshint( "effect-" + effect ); | ||
| } | ||
| console.log("testJshint", "effect-", effect); |
|
Other than removing the console log, I approve of this. 👍 |
…hey were into scale-effect file.
… have its own files
|
When building manifest, I've noticed the new puff and scale dependencies were missing. So, I've updated its manifest data (amended commit). |
Discussion on #951