jquery: Add the js class, remove the no-js one
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we place it outside the dom-ready handler to avoid FOUC/CSS reflow? |
|
Agreed. This should as early as possible and blocking, which is how modernizr does it. |
|
I guess it doesn't hurt as |
This used to be done by Modernizr until its removal in 08f27c1. Some sites apply different styling for JS-disabled environments; one such example is the jQuery UI Download Builder which expands all Themeroller knobs sections in the no-JS mode.
|
Ok, I was thinking an inline script before jQuery loaded, but this works since we're not loading jQuery async. |
timmywil
approved these changes
Apr 19, 2024
|
I'm not a fan of inline scripts as they don't play nice with CSP if we ever introduce one and I didn't really want to introduce another file just for this. |
|
ah, right, and we do plan on adding CSP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be done by Modernizr until its removal in 08f27c1. Some sites apply different styling for JS-disabled environments; one such example is the jQuery UI Download Builder which expands all Themeroller knobs sections in the no-JS mode.