Skip to content

Commit 074a326

Browse files
committed
fixup! Core: Drop support for IE <11, iOS <10, Android Browser & PhantomJS
1 parent 3f1da55 commit 074a326

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

src/core/isAttached.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,12 @@ define( [
1010
},
1111
composed = { composed: true };
1212

13+
// Support: IE 9 - 11+, Edge 12 - 18+, iOS 10.0 - 10.2 only
1314
// Check attachment across shadow DOM boundaries when possible (gh-3504)
14-
if ( documentElement.attachShadow ) {
15+
// Support: iOS 10.0-10.2 only
16+
// Early iOS 10 versions support `attachShadow` but not `getRootNode`,
17+
// leading to errors. We need to check for `getRootNode`.
18+
if ( documentElement.getRootNode ) {
1519
isAttached = function( elem ) {
1620
return jQuery.contains( elem.ownerDocument, elem ) ||
1721
elem.getRootNode( composed ) === elem.ownerDocument;

test/unit/css.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,7 @@ QUnit.test( "show/hide detached nodes", function( assert ) {
641641
span.remove();
642642
} );
643643

644-
QUnit[ document.body.attachShadow ? "test" : "skip" ]( "show/hide shadow child nodes", function( assert ) {
644+
QUnit[ document.body.getRootNode ? "test" : "skip" ]( "show/hide shadow child nodes", function( assert ) {
645645
assert.expect( 28 );
646646
jQuery( "<div id='shadowHost'></div>" ).appendTo( "#qunit-fixture" );
647647
var shadowHost = document.querySelector( "#shadowHost" );
@@ -1023,7 +1023,7 @@ QUnit[ jQuery.find.compile && jQuery.fn.toggle ? "test" : "skip" ]( "detached to
10231023
"cascade-hidden element in detached tree" );
10241024
} );
10251025

1026-
QUnit[ jQuery.find.compile && jQuery.fn.toggle && document.body.attachShadow ? "test" : "skip" ]( "shadow toggle()", function( assert ) {
1026+
QUnit[ jQuery.find.compile && jQuery.fn.toggle && document.body.getRootNode ? "test" : "skip" ]( "shadow toggle()", function( assert ) {
10271027
assert.expect( 4 );
10281028
jQuery( "<div id='shadowHost'></div>" ).appendTo( "#qunit-fixture" );
10291029
var shadowHost = document.querySelector( "#shadowHost" );

test/unit/effects.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ supportjQuery.each( hideOptions, function( type, setup ) {
221221
assert.expectJqData( this, $span, "olddisplay" );
222222
} );
223223

224-
QUnit[ document.body.attachShadow ? "test" : "skip" ](
224+
QUnit[ document.body.getRootNode ? "test" : "skip" ](
225225
"Persist correct display value - " + type + " hidden, shadow child", function( assert ) {
226226
assert.expect( 3 );
227227

0 commit comments

Comments
 (0)