You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
what do you think about changing postinstall to prepublish. That's really what it should be anyways - and if you ever decide to publish this somewhere, it will actually work o_O?
The reason will be displayed to describe this comment to others. Learn more.
@fat: afaik it should be around install. Because one of the steps of the build proces is creating ./dest/jquery.js (which is the main file, without that one can't use jQuery as module from another module that has "dependencies: {"jquery": .. and does require( 'jquery' );). So from just npm install it should at least "work".
We could split it up into different tasks, of course :)
The reason will be displayed to describe this comment to others. Learn more.
Yea, prepublish is what most people use in the npm community as a courtesy though. The idea being that you should distribute the built files so that when people download a package they don't have to have the extra rebuild/compile step (and can avoid extra dependencies like grunt).
@jed gave a talk on npm at txjs where he talked about a similar issue with people publishing coffee script packages and suggested this (prepublish) hook pattern.
d5658e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about changing
postinstall
toprepublish
. That's really what it should be anyways - and if you ever decide to publish this somewhere, it will actually work o_O?d5658e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This revert forgot to remove property
"main"
as well (see 286c4d9). Fixed in 3c86547.d5658e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fat: afaik it should be around
install
. Because one of the steps of the build proces is creating./dest/jquery.js
(which is the main file, without that one can't use jQuery as module from another module that has"dependencies: {"jquery": ..
and doesrequire( 'jquery' );
). So from justnpm install
it should at least "work".We could split it up into different tasks, of course :)
See also http://npmjs.org/doc/scripts.html
d5658e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, prepublish is what most people use in the npm community as a courtesy though. The idea being that you should distribute the built files so that when people download a package they don't have to have the extra rebuild/compile step (and can avoid extra dependencies like grunt).
@jed gave a talk on npm at txjs where he talked about a similar issue with people publishing coffee script packages and suggested this (prepublish) hook pattern.