Skip to content
Permalink
Browse files

Removes scripts:postinstall from package.json, see: 286c4d9

  • Loading branch information...
rwaldron committed Jun 21, 2012
1 parent 26bdbb8 commit d5658e978d9a7234e537d57c45069ce223cb3853
Showing with 1 addition and 4 deletions.
  1. +1 −4 package.json
@@ -31,8 +31,5 @@
"grunt": ">=0.3.9",
"testswarm": "0.2.2"
},
"keywords": [],
"scripts": {
"postinstall": "./node_modules/grunt/bin/grunt"
}
"keywords": []
}

4 comments on commit d5658e9

@fat

This comment has been minimized.

Copy link
Contributor

replied Jun 22, 2012

what do you think about changing postinstall to prepublish. That's really what it should be anyways - and if you ever decide to publish this somewhere, it will actually work o_O?

@Krinkle

This comment has been minimized.

Copy link
Member

replied Jun 26, 2012

This revert forgot to remove property "main" as well (see 286c4d9). Fixed in 3c86547.

@Krinkle

This comment has been minimized.

Copy link
Member

replied Jun 26, 2012

@fat: afaik it should be around install. Because one of the steps of the build proces is creating ./dest/jquery.js (which is the main file, without that one can't use jQuery as module from another module that has "dependencies: {"jquery": .. and does require( 'jquery' );). So from just npm install it should at least "work".

We could split it up into different tasks, of course :)

See also http://npmjs.org/doc/scripts.html

@fat

This comment has been minimized.

Copy link
Contributor

replied Jun 27, 2012

Yea, prepublish is what most people use in the npm community as a courtesy though. The idea being that you should distribute the built files so that when people download a package they don't have to have the extra rebuild/compile step (and can avoid extra dependencies like grunt).

@jed gave a talk on npm at txjs where he talked about a similar issue with people publishing coffee script packages and suggested this (prepublish) hook pattern.

Please sign in to comment.
You can’t perform that action at this time.