rm redundant jQuery wrapping to find value of element

[arjun024]

No description provided.

[Kangaroopower]

Are you sure this change isn't against the style guide?

[arjun024]

Yes. i checked. First commit is to make it conform to style guide.

[dmethvin]

Not sure why jscs didn't catch this, but it should be ( "

[dmethvin]

@arjun024 Can you reply on the questions when you get a second? It may be fine but I'm counting on you to answer so I can be lazy. 😄

[arjun024]

@dmethvin valhook for option was removed in a previous commit. (see fdd78fa)

[arjun024]

@dmethvin option.value will also fallback to the the option text if value attribute isn't specified. the wrapping is redundant.

[dmethvin]

What has me confused is that this has other patches in the diff other than yours. Can you rebase against the current master? Also, for your own sanity you should work in a branch and not in your master. If you are lucky it will be as easy as pull --rebase upstream master to rebase, but if you have made other changes since this it will be a mess.

[arjun024]

@dmethvin I have rebased against the current master. Yes, I understand it's a bad idea to work on master. thanks for the tip :)

[dmethvin]

Actually, option.value won't fall back reliably in all browsers so we have to leave that in. See

jquery/src/attributes/val.js

Line 73 in 541e734

valHooks: {