Add support to tag-hyphenated elements #1988

LeonardoBraga · 2015-01-04T00:02:23Z

Fixes #1987

rwaldron · 2015-01-04T00:17:45Z

test/unit/core.js

@@ -627,6 +627,7 @@ test("jQuery('html')", function() {

 	ok( jQuery("<div></div>")[0], "Create a div with closing tag." );
 	ok( jQuery("<table></table>")[0], "Create a table with closing tag." );
+	ok( jQuery("<tr-d></tr-d>")[0], "Create a dash-delimited tag." );


I don't mean to be pedantic, but that's not "delimited". Suggest: "hyphenated".

Not a problem! I changed as suggested. Please let me know if anything requires adjustments.

markelog · 2015-01-04T13:37:59Z

test/unit/manipulation.js

@@ -1620,6 +1620,8 @@ function testHtml( valueObj ) {
 	tmp = " " + tmp.slice( 1 );
 	equal( div.html(valueObj( tmp )).html().replace( />/g, "&gt;" ), tmp, "Escaped html, leading space" );

+	equal( jQuery("<tr-d></tr-d><tr-d></tr-d>").length, 2, "Create tag-hyphenated elements." );


I would want more assertions for this, so it would be more thorough, like check for nodeName and for other elements like this. No need to do this for core module though.

And i would prefer if those assertions would be in different test.

And maybe a case with two (or more) hyphens, just in case. It's obvious current implementation will work in the same way but it's better to be future-proof.

+1 the more tests the better, especially if this involves regexps

markelog · 2015-01-04T13:42:17Z

Could break this pull on two commits? One for core, other for manipulation, i think it would be best way to do this. You can squash other commits, don't need them.

Also please verify these changes would work in compat branch.

LeonardoBraga · 2015-01-04T18:29:36Z

I'm implementing the requested changes and will update this PR soon, however I noticed that rsingleTag does not contain :, while rtagName does. Shouldn't we add : to rsingleTag in order to keep consistency?

markelog · 2015-01-04T20:04:26Z

@LeonardoBraga i guess you missed my comment - #1988 (comment)

LeonardoBraga · 2015-01-04T21:41:49Z

@markelog Applied and tested the changes locally on compat and they seem to be fine. Should I provide a PR for that branch too?

markelog · 2015-01-04T21:45:49Z

test/unit/core.js

+
+	var j = jQuery("<tr-d></tr-d>"); 
+	ok( j[0], "Create a tag-hyphenated elements" );
+	equal( j[0].nodeName, "TR-D", "Tag-hyphenated element has expected node name" );


use jQuery.nodeName here

markelog · 2015-01-04T21:54:24Z

In #1988 (comment), i meant all of them, like here - https://github.com/jquery/jquery/blob/66e1b6b8d49812239b5712d65922ff94c60f7b02/test/unit/manipulation.js#L264-268, just to be safe

markelog · 2015-01-04T21:55:03Z

Should I provide a PR for that branch too?

That would be preferable

Fixes #1987

gibson042 · 2015-01-11T16:46:20Z

@gkalpak makes a valid point... in fact, HTML tag names must start with an ASCII letter, but can then include almost anything. Let's update all three regular expressions accordingly, so that the capture consists of a case-insensitive a–z and any number of non-whitespace non-slash non-greater-than non-NULL characters.

dmethvin · 2015-01-11T21:23:11Z

Wow, so ASCII letters are just lowercased and pretty much any other non-space character is allowed. That's mighty liberal. So it does sound like we need to adjust our regex-en (or whatever the plural of regex is).

LeonardoBraga · 2015-01-12T04:24:39Z

I'll update this PR to also address the concerns regarding valid tag names.

Regarding the previous state, it's not clear to me how we stand on:

Should I add : to all regexes (trusting Wikipedia on the plural here) to keep consistency or leave them as they are? This might mean a few extra bytes, but it's a "price" worth paying for consistency, IMO.
Should I extend all the tests cases that I added for - to also test : or this is not necessary?

Thank you - I'm glad this exposed some other cases that needed attention as well. I'll try to wrap up this quickly.

gibson042 · 2015-01-12T15:15:41Z

I stand by my previous position, because ":" is special.

We want no ":" in rsingleTag so elements with the character in their name are created by the namespace-aware innerHTML instead of the namespace-ignorant document.createElement: https://rawgit.com/gibson042/fdedc0a26c25ffbfc014/raw/9a5487e7aad4282641a498bf95ccd9299a747c16/rdf.xhtml

We want a ":" in rtagName and rxhtmlTag so the former correctly identifies the first open tag and the latter doesn't mangle input: http://jsfiddle.net/5y6p8777/

Where the statements now refer to acceptance of the character, rather than its literal appearance in the regex.

markelog · 2015-01-12T15:52:50Z

I think we should merge this as is, this PR solves real problem that users faced, "almost anything" is nice to have and could be solved in another PR

markelog · 2015-01-14T01:56:08Z

This, and i can't believe we forgot about it, doesn't work in IE8, remember why we have the shim?

Right, now i do too. My first thought was to revert, now i think we should blacklist those hyphenated tests for the old one. Since if user uses custom elements he definitely doesn't use it with IE8.

dmethvin · 2015-01-14T02:08:28Z

😈

I don't think we need to revert, we can just skip it for IE8.

markelog · 2015-01-14T02:16:16Z

we can just skip it for IE8.

Will do that.

@LeonardoBraga note that you would have to do the same thing for #2005

LeonardoBraga · 2015-01-14T02:21:01Z

you would have to do the same thing

Do you mean to blacklist the tests I'll write for IE8? If so, is there a place where this is already done in the code so I can follow the same pattern?

markelog · 2015-01-14T02:27:48Z

See the 87bb713

mgol · 2015-01-14T02:28:38Z

This, and i can't believe we forgot about it, doesn't work in IE8, remember why we have the shim?

Isn't it enough to document.createElement it to make IE8 recognize it? The developer might be doing that and using custom tags on IE8 so maybe we should test this scenario.

markelog · 2015-01-14T02:45:51Z

Isn't it enough to document.createElement it to make IE8 recognize it?

Yes.

The developer might be doing that and using custom tags on IE8 so maybe we should test this scenario.

Even though this is unlikely use-case, we still can't do that, oldIE will identify only those elements that created in the scope of the document it first added to, which is in our case, is internal documentFragment element, which is not exposed.

dmethvin · 2015-01-14T02:49:52Z

I thought for sure IE8 would die on special chars but at least that part works. I don't think we want to guarantee this madness works consistently in IE8 anyway.

gibson042 · 2015-01-14T02:58:18Z

I don't think we want to guarantee this madness works consistently in IE8 anyway.

Agreed. As long as our code is solid, it's OK for some edge cases to fail on IE8.

markelog · 2015-01-14T03:06:05Z

I thought for sure IE8 would die on special chars but at least that part works.

If wouldn't do something crazy like find those elems in user string and create them on our documentFragment it wouldn't work for the same reason hyphenated elements fall through the cracks.

mbest · 2015-09-24T10:00:29Z

Why is this only being fixed in version 3.0.0? For anyone using jQuery for template-like support across multiple browsers, this change is essential for full support of custom elements. I think it should be back ported to 1.x and 2.x. This shouldn't be hard since it's a small, non-breaking change.

Fixes #1987 Closes gh-1988

…round Note jQuery bug at jquery/jquery#1988.

mgol · 2016-03-06T13:39:51Z

This has been backported to 1.12.0 & 2.2.0 so I changed the milestone (it used to say 3.0.0).

mgol · 2016-03-07T17:55:00Z

I moved the milestone from this PR to the issue #1987.

Ref jquery#1988 (comment)

rwaldron reviewed Jan 4, 2015
View reviewed changes

LeonardoBraga changed the title ~~Core: Add support to dash-delimited elements~~ Core: Add support to tag-hyphenated elements Jan 4, 2015

markelog reviewed Jan 4, 2015
View reviewed changes

LeonardoBraga added 2 commits January 4, 2015 19:03

Core: Add support to tag-hyphenated elements

3f57cea

Fixes #1987

Manipulation: Add support to tag-hyphenated elements

a65f365

Fixes #1987

dmethvin added this to the 3.0.0 milestone Jan 5, 2015

markelog closed this in 85ffc6d Jan 13, 2015

markelog changed the title ~~Core: Add support to tag-hyphenated elements~~ Add support to tag-hyphenated elements Jan 13, 2015

This was referenced Jan 13, 2015

Improve tag name related regexes #2005

Closed

Add tests for namespaced tags #2006

Closed

mbest mentioned this pull request Sep 24, 2015

Removing jQuery HTML parsing by default is breaking knockout/knockout#1880

Merged

LeonardoBraga mentioned this pull request Oct 7, 2015

Manipulation: Bring tagname regexes up to spec #2634

Closed

markelog pushed a commit that referenced this pull request Nov 10, 2015

Manipulation: add support to tag-hyphenated elements

69dda5b

Fixes #1987 Closes gh-1988

brianmhunt added a commit to knockout/tko that referenced this pull request Dec 20, 2015

#1) Drop <ie8 hack; prefer <template> parsing; drop tagWithDash worka…

efe6c59

…round Note jQuery bug at jquery/jquery#1988.

mgol modified the milestones: 1.12.0/2.2.0, 3.0.0 Mar 6, 2016

mgol removed this from the 1.12.0/2.2.0 milestone Mar 7, 2016

gibson042 added a commit to gibson042/jquery that referenced this pull request Jul 11, 2018

Manipulation: Improve regex documentation

f082845

Ref jquery#1988 (comment)

gibson042 added a commit to gibson042/jquery that referenced this pull request Jul 11, 2018

Manipulation: Improve regex documentation

a46f74c

Ref jquery#1988 (comment)

gibson042 added a commit to gibson042/jquery that referenced this pull request Jul 11, 2018

Manipulation: Improve regex documentation

762f859

Ref jquery#1988 (comment)

lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to tag-hyphenated elements #1988

Add support to tag-hyphenated elements #1988

LeonardoBraga commented Jan 4, 2015

rwaldron Jan 4, 2015

LeonardoBraga Jan 4, 2015

markelog Jan 4, 2015

mgol Jan 4, 2015

markelog Jan 4, 2015

markelog commented Jan 4, 2015

LeonardoBraga commented Jan 4, 2015

markelog commented Jan 4, 2015

LeonardoBraga commented Jan 4, 2015

markelog Jan 4, 2015

markelog commented Jan 4, 2015

markelog commented Jan 4, 2015

gibson042 commented Jan 11, 2015

dmethvin commented Jan 11, 2015

LeonardoBraga commented Jan 12, 2015

gibson042 commented Jan 12, 2015

markelog commented Jan 12, 2015

markelog commented Jan 14, 2015

dmethvin commented Jan 14, 2015

markelog commented Jan 14, 2015

LeonardoBraga commented Jan 14, 2015

markelog commented Jan 14, 2015

mgol commented Jan 14, 2015

markelog commented Jan 14, 2015

dmethvin commented Jan 14, 2015

gibson042 commented Jan 14, 2015

markelog commented Jan 14, 2015

mbest commented Sep 24, 2015

mgol commented Mar 6, 2016

mgol commented Mar 7, 2016

Add support to tag-hyphenated elements #1988

Add support to tag-hyphenated elements #1988

Conversation

LeonardoBraga commented Jan 4, 2015

rwaldron Jan 4, 2015

Choose a reason for hiding this comment

LeonardoBraga Jan 4, 2015

Choose a reason for hiding this comment

markelog Jan 4, 2015

Choose a reason for hiding this comment

mgol Jan 4, 2015

Choose a reason for hiding this comment

markelog Jan 4, 2015

Choose a reason for hiding this comment

markelog commented Jan 4, 2015

LeonardoBraga commented Jan 4, 2015

markelog commented Jan 4, 2015

LeonardoBraga commented Jan 4, 2015

markelog Jan 4, 2015

Choose a reason for hiding this comment

markelog commented Jan 4, 2015

markelog commented Jan 4, 2015

gibson042 commented Jan 11, 2015

dmethvin commented Jan 11, 2015

LeonardoBraga commented Jan 12, 2015

gibson042 commented Jan 12, 2015

markelog commented Jan 12, 2015

markelog commented Jan 14, 2015

dmethvin commented Jan 14, 2015

markelog commented Jan 14, 2015

LeonardoBraga commented Jan 14, 2015

markelog commented Jan 14, 2015

mgol commented Jan 14, 2015

markelog commented Jan 14, 2015

dmethvin commented Jan 14, 2015

gibson042 commented Jan 14, 2015

markelog commented Jan 14, 2015

mbest commented Sep 24, 2015

mgol commented Mar 6, 2016

mgol commented Mar 7, 2016