-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS: Don't automatically add "px" to properties with a few exceptions #4055
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
define( function() { | ||
|
||
"use strict"; | ||
|
||
var ralphaStart = /^[a-z]/, | ||
|
||
// The regex visualized: | ||
// | ||
// /----------\ | ||
// | | /-------\ | ||
// | / Top \ | | | | ||
// /--- Border ---+-| Right |-+---+- Width -+---\ | ||
// | | Bottom | | | ||
// | \ Left / | | ||
// | | | ||
// | /----------\ | | ||
// | /-------------\ | | |- END | ||
// | | | | / Top \ | | | ||
// | | / Margin \ | | | Right | | | | ||
// |---------+-| |-+---+-| Bottom |-+----| | ||
// | \ Padding / \ Left / | | ||
// BEGIN -| | | ||
// | /---------\ | | ||
// | | | | | ||
// | | / Min \ | / Width \ | | ||
// \--------------+-| |-+---| |---/ | ||
// \ Max / \ Height / | ||
rautoPx = /^(?:Border(?:Top|Right|Bottom|Left)?(?:Width|)|(?:Margin|Padding)?(?:Top|Right|Bottom|Left)?|(?:Min|Max)?(?:Width|Height))$/; | ||
|
||
function isAutoPx( prop ) { | ||
|
||
// The first test is used to ensure that: | ||
// 1. The prop starts with a lowercase letter (as we uppercase it for the second regex). | ||
// 2. The prop is not empty. | ||
return ralphaStart.test( prop ) && | ||
rautoPx.test( prop[ 0 ].toUpperCase() + prop.slice( 1 ) ); | ||
}; | ||
|
||
return isAutoPx; | ||
|
||
} ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this change, effects tests were failing on non-element objects on an
a
property. I've noticed they were already failing ifa
was changed to anything fromjQuery.cssNumber
and this PR makes almost everything "like fromjQuery.cssNumber
".The
nodeType
check should most likely already be there, perhaps we should add it for 3.4.0 as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ugh. Put another way, we only want to add "px" to property values if they're on DOM elements. I still wish we hadn't supported animating plain objects,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted this change to PR #4061.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4601 landed, this PR rebased so this particular change is no longer a part of this PR.