Event: Use only one focusin/out handler per matching window & document #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added
Bug
Event
Needs review
Discuss in Meeting
mgol
force-pushed
the
3.x-focusin-window-document
branch
2 times, most recently
from
0a19d1a
to
2e48489
Compare
mgol
commented
Apr 6, 2020
|
|
||
| // DOM focus is unreliable in TestSwarm | ||
| if ( QUnit.isSwarm && !focus ) { | ||
| assert.ok( true, "GAP: Could not observe focus change" ); |
There was a problem hiding this comment.
@gibson042 BTW, I copied this from other similar assertions but... what is GAP?
There was a problem hiding this comment.
My attempt to make clear that this is not a true passing assertion, but rather a failure to verify the desired assertion at all... a gap between intent and capability.
There was a problem hiding this comment.
Ah. Since it’s all uppercase, I thought it’s an acronym. 😅
mgol
force-pushed
the
3.x-focusin-window-document
branch
from
2e48489
to
6f78bba
Compare
timmywil
removed
the
Discuss in Meeting
… document The `doc` variable in: https://github.com/jquery/jquery/blob/3.4.1/src/event/focusin.js#L30 matched `document` for `document` & `window` for `window`, creating two separate wrapper event handlers & calling handlers twice if at least one `focusout` or `focusin` handler was attached on *both* `window` & `document`, or on `window` & another regular node. Also, fix the "focusin from an iframe" test to actually verify the behavior from commit 1cecf64 - the commit that introduced the regression - to make sure we don't regress on either front.
mgol
force-pushed
the
3.x-focusin-window-document
branch
from
6f78bba
to
a236eca
Compare
mgol
changed the title
mgol
referenced
this pull request
Apr 6, 2020
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 6, 2020
Backport tests from a jQuery 3.x fix that's not needed on `master`. Also, fix the "focusin from an iframe" test to actually verify the behavior from commit 1cecf64 - the commit that introduced the regression - to make sure we don't regress on either front. The main part of the modified test was checking that focusin handling in an iframe works and that's still checked. The test was also checking that it doesn't propagate to the parent document, though, and, apparently, in IE it does. This one test is now blacklisted in IE. (cherry picked from 9e15d6b) (cherry picked from 1a4f10d) Ref jquerygh-4652 Ref jquerygh-4656
3 tasks
|
Tests backported to |
mgol
added a commit
that referenced
this pull request
Apr 27, 2020
Backport tests from a jQuery 3.x fix that's not needed on `master`. Also, fix the "focusin from an iframe" test to actually verify the behavior from commit 1cecf64 - the commit that introduced the regression - to make sure we don't regress on either front. The main part of the modified test was checking that focusin handling in an iframe works and that's still checked. The test was also checking that it doesn't propagate to the parent document, though, and, apparently, in IE it does. This one test is now blacklisted in IE. (cherry picked from 9e15d6b) (cherry picked from 1a4f10d) Ref gh-4652 Ref gh-4656 Closes gh-4657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
docvariable in:https://github.com/jquery/jquery/blob/3.4.1/src/event/focusin.js#L30
matched
documentfordocument&windowforwindow, creating two separatewrapper event handlers & calling handlers twice if at least one
focusoutorfocusinhandler was attached on bothwindow&document, or onwindow& another regular node.
Also, fix the "focusin from an iframe" test to actually verify the behavior
from commit 1cecf64 - the commit that
introduced the regression - to make sure we don't regress on either front.
+5 bytes.
Test updates should be cherry-picked to
masterwithout any source changes.Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com