Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax-and-forms content; code formatting issue fixes; etc #56

Merged
merged 15 commits into from
Mar 13, 2012
Merged

Ajax-and-forms content; code formatting issue fixes; etc #56

merged 15 commits into from
Mar 13, 2012

Conversation

connor
Copy link
Contributor

@connor connor commented Feb 20, 2012

This contains the following:

  • ajax/ajax-and-forms content (as per issue Content-review: $.ajax() #38 discussion and Addy's comments) with updated stuff including:
    • serialization
    • prefiltering
    • client-side validation
  • fixing a bunch of code formatting issues on the examples
  • changing the info in the footer from jQuery 1.5.x to jQuery 1.7.1 (also adding links)
  • Adjust the regex nanoc uses so we can use single quotes in the captions (fixes issue Nanoc inflexibility #59)

@connor connor mentioned this pull request Feb 21, 2012
@ajpiano
Copy link
Member

ajpiano commented Mar 13, 2012

hey @ConnorMontgomery, thanks for pitching in! all these changes look good, and i just checked the quote thing out as well and it's working well! looking forward to having you involved as we ramp this whole site back up and get it shipped!

for this initial set of changes, i'll merge this PR as it applies cleanly, but you'll probably end up needing to clean up your own master branch to be able to apply these changes once merged. in the future, you'll want to start doing all your work in separate branches (not committing on master), and doing separate pull requests for individual atomic issues. this will make it a lot easier for you (or anyone else reading this :) ) to keep master up to date, and pull down and try out pull requests locally, and generally avoid other un-fun nonsense. let me know if you have any questions about this workflow!

ajpiano added a commit that referenced this pull request Mar 13, 2012
Ajax-and-forms content; code formatting issue fixes; etc
@ajpiano ajpiano merged commit 0313baa into jquery:master Mar 13, 2012
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Ajax-and-forms content; code formatting issue fixes; etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants