Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chi square procedure #14

Merged
merged 6 commits into from
Aug 31, 2021
Merged

Conversation

imathews
Copy link
Collaborator

This is a WIP of implementing chi-square as a stored procedure, where the user passes in a table name and column names to be computed on.

I followed the testing convention of the other stored procedure, get_next_id, where the test is just inlined in the procedure.

Important: this isn't yet ready to merge, there's something wrong in my math for the chi-square test, and I need to clean up the test case.

@imathews imathews marked this pull request as ready for review August 18, 2021 23:59
Copy link
Owner

@jrossthomson jrossthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrossthomson jrossthomson merged commit f28951e into master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants