Remove remaining "19" methods

These methods were not deprecated before JRuby 10, so they were
left in place for one additional "major" release. This deletes
them.

They are very low risk of causing compile or execution problems,
but this safer approach gives any remaining users a full version
cycle to switch to the long-available normal versions.

See #8143 for the original pass that removed already-
deprecated methods.

Author: headius

core/src/main/java/org/jruby/RubyArray.java

@@ -2078,11 +2078,6 @@ private void recursiveJoin(final ThreadContext context, final IRubyObject outVal
         context.safeRecurse(JOIN_RECURSIVE, new JoinRecursive.State(ary, outValue, sep, result, first), outValue, "join", true);
     }
 
-    @Deprecated
-    public IRubyObject join19(final ThreadContext context, IRubyObject sep) {
-        return join(context, sep);
-    }
-
     /** rb_ary_join
      *
      */
@@ -2124,11 +2119,6 @@ public IRubyObject join(final ThreadContext context, IRubyObject sep) {
         return result;
     }
 
-    @Deprecated
-    public IRubyObject join19(ThreadContext context) {
-        return join(context);
-    }
-
     @JRubyMethod(name = "join")
     public IRubyObject join(ThreadContext context) {
         return join(context, getDefaultSeparator(context.runtime));

core/src/main/java/org/jruby/RubyDir.java

@@ -486,11 +486,6 @@ public static RubyArray children(ThreadContext context, IRubyObject recv, IRubyO
         return dir.children(context);
     }
 
-    @Deprecated
-    public static IRubyObject rmdir19(IRubyObject recv, IRubyObject path) {
-        return rmdir(recv.getRuntime().getCurrentContext(), recv, path);
-    }
-
     /**
      * Deletes the directory specified by <code>path</code>.  The directory must be empty.
      */

core/src/main/java/org/jruby/RubyFile.java

@@ -1268,11 +1268,6 @@ public static IRubyObject readlink(ThreadContext context, IRubyObject recv, IRub
         }
     }
 
-    @Deprecated
-    public static IRubyObject truncate19(ThreadContext context, IRubyObject recv, IRubyObject arg1, IRubyObject arg2) {
-        return truncate(context, recv, arg1, arg2);
-    }
-
     // Can we produce IOError which bypasses a close?
     @JRubyMethod(name = "truncate", meta = true)
     public static IRubyObject truncate(ThreadContext context, IRubyObject recv, IRubyObject arg1, IRubyObject arg2) {

core/src/main/java/org/jruby/RubyFileStat.java

@@ -142,11 +142,6 @@ private void setup(String filename, boolean lstat) {
         }
     }
 
-    @Deprecated
-    public IRubyObject initialize19(IRubyObject fname, Block unusedBlock) {
-        return initialize(fname, unusedBlock);
-    }
-
     @JRubyMethod(name = "initialize", visibility = Visibility.PRIVATE)
     public IRubyObject initialize(IRubyObject fname, Block unusedBlock) {
         Ruby runtime = getRuntime();

core/src/main/java/org/jruby/RubyMatchData.java

@@ -673,11 +673,6 @@ public IRubyObject end(ThreadContext context, IRubyObject index) {
         return RubyFixnum.newFixnum(runtime, e);
     }
 
-    @Deprecated
-    public IRubyObject offset19(ThreadContext context, IRubyObject index) {
-        return offset(context, index);
-    }
-
     /** match_offset
      *
      */

core/src/main/java/org/jruby/RubyMath.java

@@ -370,11 +370,6 @@ public static RubyFloat cbrt(ThreadContext context, IRubyObject recv, IRubyObjec
         return RubyFloat.newFloat(context.runtime, result);
     }
 
-    @Deprecated
-    public static RubyFloat hypot19(ThreadContext context, IRubyObject recv, IRubyObject x, IRubyObject y) {
-        return hypot(context, recv, x, y);
-    }    
-
     @JRubyMethod(name = "hypot", module = true, visibility = Visibility.PRIVATE)
     public static RubyFloat hypot(ThreadContext context, IRubyObject recv, IRubyObject x, IRubyObject y) {
         double valuea = RubyNumeric.num2dbl(context, x);

core/src/main/java/org/jruby/RubyModule.java

@@ -3200,23 +3200,13 @@ protected void addMethodSymbols(Ruby runtime, Set<String> seen, RubyArray ary, b
         });
     }
 
-    @Deprecated
-    public RubyArray instance_methods19(IRubyObject[] args) {
-        return instance_methods(args);
-    }
-
     @JRubyMethod(name = "instance_methods", optional = 1, checkArity = false)
     public RubyArray instance_methods(IRubyObject[] args) {
         Arity.checkArgumentCount(getRuntime(), args, 0, 1);
 
         return instanceMethods(args, PRIVATE, false, true);
     }
 
-    @Deprecated
-    public RubyArray public_instance_methods19(IRubyObject[] args) {
-        return public_instance_methods(args);
-    }
-
     @JRubyMethod(name = "public_instance_methods", optional = 1, checkArity = false)
     public RubyArray public_instance_methods(IRubyObject[] args) {
         Arity.checkArgumentCount(getRuntime(), args, 0, 1);
@@ -4014,11 +4004,6 @@ public IRubyObject class_variable_defined_p(ThreadContext context, IRubyObject v
         return context.fals;
     }
 
-    @Deprecated
-    public IRubyObject class_variable_get19(IRubyObject name) {
-        return class_variable_get(name);
-    }
-
     /** rb_mod_cvar_get
      *
      */
@@ -4035,11 +4020,6 @@ public IRubyObject class_variable_set(IRubyObject name, IRubyObject value) {
         return setClassVar(validateClassVariable(getRuntime(), name), value);
     }
 
-    @Deprecated
-    public IRubyObject class_variable_set19(IRubyObject name, IRubyObject value) {
-        return class_variable_set(name, value);
-    }
-
     /** rb_mod_remove_cvar
      *
      */
@@ -4048,11 +4028,6 @@ public IRubyObject remove_class_variable(ThreadContext context, IRubyObject name
         return removeClassVariable(validateClassVariable(context.runtime, name));
     }
 
-    @Deprecated
-    public IRubyObject remove_class_variable19(ThreadContext context, IRubyObject name) {
-        return remove_class_variable(context, name);
-    }
-
     @JRubyMethod(name = "class_variables")
     public RubyArray class_variables(ThreadContext context) {
         Ruby runtime = context.runtime;

core/src/main/java/org/jruby/RubyProcess.java

@@ -1819,11 +1819,6 @@ public static IRubyObject _fork(ThreadContext context, IRubyObject recv, Block b
         throw context.runtime.newNotImplementedError("fork is not available on this platform");
     }
 
-    @Deprecated
-    public static IRubyObject fork19(ThreadContext context, IRubyObject recv, Block block) {
-        return fork(context, recv, block);
-    }
-
     @JRubyMethod(name = "fork", module = true, visibility = PRIVATE, notImplemented = true)
     public static IRubyObject fork(ThreadContext context, IRubyObject recv, Block block) {
         return RubyKernel.fork(context, recv, block);