-
-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java jruby-complete-9.3.4.0.jar org.jruby.Main -rjars/setup -S gem install --debug --backtrace msgpack -v 1.1.0 failed windos-latest environment only. #7182
Comments
It seems that uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/resolver.rb:176:in `output' 173 include Molinillo::UI
174
175 def output
176 @output ||= debug? ? $stdout : File.open(IO::NULL, 'w')
177 end https://github.com/hiroyuki-sato/embulk-ci-test/runs/6173635118?check_suite_focus=true#step:4:76
|
…ions. This environment variable is necessary to avoid `gem install` error on a Windows in GitHub Actions. See also: jruby/jruby#7182 (comment)
I'll close this issue within a few days. Because I think this issue is GitHub Actions specific. 15 ##
16 # If the DEBUG_RESOLVER environment variable is set then debugging mode is
17 # enabled for the resolver. This will display information about the state
18 # of the resolver while a set of dependencies is being resolved.
19
20 DEBUG_RESOLVER = !ENV['DEBUG_RESOLVER'].nil? 179 def debug?
180 DEBUG_RESOLVER
181 end |
…ions. This environment variable is necessary to avoid `gem install` error on a Windows in GitHub Actions. See also: jruby/jruby#7182 (comment)
…ions. This environment variable is necessary to avoid `gem install` error on a Windows in GitHub Actions. See also: jruby/jruby#7182
I think we should keep this open. The resolver debugging should not break on JRuby, but it appears there's a bug that causes us to raise an error when opening the NULL device for write. |
Hello, @headius. Thank you for your comment. I keep this open. I also tested the following code using CRuby on windows-latest in GitHub Actions. #!/usr/bin/env ruby
File.open(IO::NULL,'w'){} https://github.com/hiroyuki-sato/embulk-ci-test/ https://github.com/hiroyuki-sato/embulk-ci-test/runs/6185552371?check_suite_focus=true |
I'll double-check later, but this issue is Zulu SDK-specific. The difference is the NG Case: https://github.com/hiroyuki-sato/embulk-ci-test/actions/runs/2233437492 name: Check
on: [ push, pull_request ]
jobs:
check:
runs-on: ${{ matrix.os }}
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
- macOS-latest
- windows-latest
gradle_task:
- "check"
steps:
- uses: actions/checkout@v2
- name: Set up OpenJDK 8
uses: actions/setup-java@v2
with:
java-version: 8
# distribution: "adopt"
distribution: "zulu"
- name: Check
run: ./gradlew --debug ${{ matrix.gradle_task }} OK Case: https://github.com/hiroyuki-sato/embulk-ci-test/actions/runs/2233515348 name: Check
on: [ push, pull_request ]
jobs:
check:
runs-on: ${{ matrix.os }}
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
- macOS-latest
- windows-latest
gradle_task:
- "check"
steps:
- uses: actions/checkout@v2
- name: Set up OpenJDK 8
uses: actions/setup-java@v2
with:
java-version: 8
distribution: "adopt"
# distribution: "zulu"
- name: Check
run: ./gradlew --debug ${{ matrix.gradle_task }} |
Aha that is very interesting! I have some other issues with Zulu that I need to report, so I can add this to the list. |
Hello, @headius. Thank you for your comment. I double-checked Test code in File.open(IO::NULL,'w'){}
|
I can confirm the issue also exists using Adoptium 17.0.3_7 on Windows.
|
This may mean that some newer behavior from later JDKs was incorporated into the builds of Zulu 8, or it may mean this is not specific to Zulu after all. I have reached out to the Zulu folks at Azul to help investigate this. |
Hi, Try to use command line option |
I confirm the workaround to be functional for Adoptium 17.0.3_7. Thanks!
|
Thanks for quick check. |
It also looks like that fix is coming to JDK updates as far back as 8 so I think this is an acceptable work around and out of our hands. Thanks for the footwork everyone! |
Thanks, @headius, @sashaioffe, and @afischer-opentext-com |
* This reverts commit b2027b6. * No longer needed (actions/runner-images@2900984).
This is fixed on GitHub Actions with the newer JDK: actions/runner-images@2900984 |
Hello, JRuby developers.
Environment Information
Provide at least:
jruby -v
) and command line (flags, JRUBY_OPTS, etc): 9.3.4.0uname -a
): windows-latest in GitHub Actions.Other relevant info you may wish to add: (Please see below)
Expected Behavior
java jruby-complete-9.3.4.0.jar org.jruby.Main -rjars/setup -S gem install --debug --backtrace msgpack -v 1.1.0
installed gem onwindows-latest
environment.Actual Behavior
The following command failed with
windows-latest
in GitHub Actions. (I can't reprodude this behavior in my Windows 10 environment.)ubuntu-latest
andmacOS-latest
worked fine.Does anyone advise me on how to investigate this issue?
Reproduce steps.
The text was updated successfully, but these errors were encountered: