get_fxml_loader seems to work differently when in jar

[amiracam]

So I have managed to pack up app in a jar which then upon launching the jar I encounter this:

 fx.location =
      if JRubyFX::Application.in_jar?
      # If we are in a jar file, use the class loader to get the file from the jar (like java)
      # TODO: should just be able to use URLs
      JRuby.runtime.jruby_class_loader.get_resource File.join(root_dir, filename)
    else
      root_dir ||= fxml_root
      # If we are in the normal filesystem, create a file url path relative to relative_to or this file
      URL.new "file:#{File.join root_dir, filename}"
    end

the app upon launching ie.

  java -jar myjar.jar

crashes in the attempt to do the file join because <root_dir> is nil although fxml_root was specified in the app.

Launching the app works outside of the jar , where there's protection in place to assure that root_dir has fxml_root .

From a quick glance it seems that root_dir should have? been picked up via "settings" but apparently its not. Have to go now, I'll spend more time on this tomorrow.

Here's the debug stack:

root dir : 
filename : amn_main_ui2.fxml
Exception running Application:
#<TypeError: can't convert nil into String>
org/jruby/RubyFile.java:1895:in `join'
org/jruby/RubyFile.java:826:in `join'
/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:341:in `get_fxml_loader'
/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:117:in `load_into'
./lib/amn_main_ui.rb:19:in `start'
/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/java_fx_impl.rb:125:in `launch_app_after_platform'
org/jruby/gen/InterfaceImpl1217949027.gen:13:in `run'
loading amn

[byteit101]

Did you use the jar version of *_root?

fxml_root "/full/path/in/filesystem", "path/inside/jar"

[amiracam]

No. Ideally I would hope for one relative path that would work in both
context but may be I'm missing something with regards to jar inner workings

I'll check out the the jar option

Thanks
On Nov 11, 2013 9:35 AM, "Patrick Plenefisch" notifications@github.com
wrote:

Did you use the jar version of *_root?

fxml_root "/full/path/in/filesystem", "path/inside/jar"

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-28204147
.

[edubkendo]

Ideally I would hope for one relative path that would work in both
context but may be I'm missing something with regards to jar inner workings

@amiracam It is unfortunate, but you will find many things, especially anything at all related to paths, works differently inside of a jar. This is usually a failing of java. We work around it as best we can.

If someone wrote a library that took, for instance, the methods from the pathname library, and wrapped them up in code that could handle jars easily, that would be pretty cool and very useful.

[amiracam]

Understood, thanks
On Nov 11, 2013 1:18 PM, "edubkendo" notifications@github.com wrote:

Ideally I would hope for one relative path that would work in both
context but may be I'm missing something with regards to jar inner workings

@amiracam https://github.com/amiracam It is unfortunate, but you will
find many things, especially anything at all related to paths, works
differently inside of a jar. This is usually a failing of java. We work
around it as best we can.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-28224635
.

[amiracam]

ok, I get past the "can't find my fxml" issue now but unfortunately once it does find the fxml and loads it I get the error included below, namely that AnchorPane is not a valid type. The way scene builder works is that by default AnchorPane is at the top of the visual component hierarchy i.e. so its the first component specified in my fxml.

Some things to keep in mind , Warbler is packing up my gems depending on what's specified in my gemfile. Here's are the pertinent contents of my gemfile.lock

jruby-jars (1.7.6)
jruby-rack (1.1.13.2)
jrubyfx (1.1.0-java)
jrubyfx-fxmlloader (>= 0.3)
jrubyfx-fxmlloader (0.3-java)

also:

java version "1.7.0_45"
jruby 1.7.6

I launch via "java -jar <myjar.jar>"

You will notice below that javafx.scene.layout.AnchorPane cannot be found which is its correct location:
http://docs.oracle.com/javafx/2/api/javafx/scene/layout/AnchorPane.html

so I assume that its not finding the java fx runtime ? even though that jar is present in the java jdk I'm utilizing.

enhanced debug stack:

root dir : src/lib
filename : amn_main_ui2.fxml
Fxml loader start createElement:
prefix:
localName: AnchorPane
entering getType
name var: AnchorPane
This is an unqualified class name
@classes inspect
{}
class not loaded yet
@packages inspect
["java.lang", "java.util", "javafx.collections", "javafx.geometry", "javafx.scene", "javafx.scene.control", "javafx.scene.layout", "javafx.scene.paint", "javafx.scene.web"]

entering loadTypeForPackage
packageName: java.lang.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: java.util.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.collections.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.geometry.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.control.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.layout.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.paint.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.web.AnchorPane
exiting loadTypeForPackage
Exiting getType

type:
Exception in runnable
org.jruby.exceptions.RaiseException: (LoadException) AnchorPane is not a valid type.
at RUBY.createElement(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:519)
at RUBY.processStartElement(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:435)
at RUBY.load(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:350)
at RUBY.load_into(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:117)
at lib.amn_main_ui.start(./lib/amn_main_ui.rb:19)
at RUBY.launch_app_after_platform(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/java_fx_impl.rb:125)
at org.jruby.gen.InterfaceImpl941714810.run(org/jruby/gen/InterfaceImpl941714810.gen:13)

[amiracam]

ok, if I force an import such as:

puts "attempting to force import of javafx.scene.layout.AnchorPane"
java_import 'javafx.scene.layout.AnchorPane'

i.e. at the top of fxmlloader

I get past the AnchorPane load issue but I then hit the next one which is TabPane, see stack below. So clearly the javafx runtime is available. I then went ahead and did the import for TabPane and sure enough got past that now I'm bumping into "Tab" not loading.

So there's some visibility issue going on that requires an explicit import.

Any thoughts ?

debug stack:

attempting to force import of javafx.scene.layout.AnchorPane
/Users/charles/.rvm/gems/jruby-1.7.6/gems/faraday-0.8.8/lib/faraday/request/multipart.rb:5 warning: already initialized constant DEFAULT_BOUNDARY
/Users/charles/.rvm/gems/jruby-1.7.6/gems/activesupport-3.2.13/lib/active_support/multibyte.rb:27 warning: already initialized constant VALID_CHARACTER
root dir : src/lib
filename : amn_main_ui2.fxml
Fxml loader start createElement:
prefix:
localName: AnchorPane
entering getType
name var: AnchorPane
This is an unqualified class name
@classes inspect
{}
class not loaded yet
@packages inspect
["java.lang", "java.util", "javafx.collections", "javafx.geometry", "javafx.scene", "javafx.scene.control", "javafx.scene.layout", "javafx.scene.paint", "javafx.scene.web"]

entering loadTypeForPackage
packageName: java.lang.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: java.util.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.collections.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.geometry.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.control.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.layout.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.paint.AnchorPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.web.AnchorPane
exiting loadTypeForPackage
Exiting getType

type: Java::JavafxSceneLayout::AnchorPane
Fxml loader start createElement:
prefix:
localName: children
Fxml loader start createElement:
prefix:
localName: TabPane
entering getType
name var: TabPane
This is an unqualified class name
@classes inspect
{"AnchorPane"=>Java::JavafxSceneLayout::AnchorPane}
class not loaded yet
@packages inspect
["java.lang", "java.util", "javafx.collections", "javafx.geometry", "javafx.scene", "javafx.scene.control", "javafx.scene.layout", "javafx.scene.paint", "javafx.scene.web"]

entering loadTypeForPackage
packageName: java.lang.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: java.util.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.collections.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.geometry.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.control.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.layout.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.paint.TabPane
exiting loadTypeForPackage

entering loadTypeForPackage
packageName: javafx.scene.web.TabPane
exiting loadTypeForPackage
Exiting getType

type:
Exception in runnable
org.jruby.exceptions.RaiseException: (LoadException) TabPane is not a valid type.
at RUBY.createElement(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:522)
at RUBY.processStartElement(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:438)
at RUBY.load(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloader.rb:353)
at RUBY.load_into(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:117)
at lib.amn_main_ui.start(./lib/amn_main_ui.rb:19)
at RUBY.launch_app_after_platform(/Users/charles/.rvm/gems/jruby-1.7.6/gems/jrubyfx-1.1.0-java/lib/jrubyfx/java_fx_impl.rb:125)
at org.jruby.gen.InterfaceImpl729562999.run(org/jruby/gen/InterfaceImpl729562999.gen:13)

[amiracam]

gadzooooks !!!!

what is working for me is to manually do this in my app code:

java_import 'javafx.scene.layout.AnchorPane'
java_import 'javafx.scene.control.TabPane'
java_import 'javafx.scene.control.Tab'
java_import 'javafx.scene.control.Accordion'
java_import 'javafx.scene.control.TitledPane'
and so on .....

unfortunately I can't do wildcards on the java packages so I will have to list every single UI component class or spin over an array of class names.

this has worked until I bumped into Insets, which is providing a totally different error so I'll document that in another issue.

[byteit101]

Umm... you should not need to do that. imports.rb does that. If its a git clone, you need to run rake reflect to generate it. (imports.rb is generated from the part file, and is in the root)

[amiracam]

nope, not a git clone, its the 1.1.0 / 0.3 versions of the gem. I have also
encountered the imports.rb and its populated, but how does that work in the
context of a jar file ?
Warbler is supposedly grabbing the gem dependencies based on my gem file,
but perhaps it grabs them fresh from ruby gems ? i.e. not use the locally
installed gem where imports.rb should have been properly setup

On Tuesday, November 12, 2013, Patrick Plenefisch notifications@github.com
wrote:

Umm... you should not need to do that. imports.rb does that. If its a git
clone, you need to run rake reflect to generate it. (imports.rb is
generated from the part file, and is in the root)

—
Reply to this email directly or view it on GitHub.<
https://github.com/notifications/beacon/N3oLPsRluOjhA7BB57UP5r6plhGwqZBukjNxsQ0tVn1NvGact0LMPT9wNkhRumwe.gif

Charles A. Monteiro
www.monteirosfusion.com
sent from the road

[amiracam]

maybe what I should do is do a "bundle pack" or "bundle install --deployment, forcing the local caching of the gems into the vendor dir , which warbler packages into the jar, make sure that vendor is added to the $LOAD_PATH, and defeat Warbler's grabbing of gem dependencies based on the gem file.

If I pack as per above the imports.rb should be generated appropriately. Perhaps this is what this is all about.

btw, not using jrubyfx's jarify cuz it does compile source, warbler works pretty well except for a couple benign issues

[amiracam]

hmmm, I inspected the generated jar file , found imports.rb to have its LOCAL_NAME_MAP generated which included Insets.

I have otherwise tested that the captured gems are in the load_path

[illtellyoulater]

I think I'm seeing the same issue:

I packed JRubyFx gem into "jruby-complete-1.7.8.jar" by doing "jar uf jruby-complete-1.7.8.jar -C JRubyFx_folder ." (I had previously put JRubyFx in there with "java -jar jruby-complete-1.7.8.jar -S gem install -i ./JRubyFx_folder jrubyfx".

The main app requiring jrubyfx and .fxml files are outside the jar so I lauch the app with "java -jar jruby-complete-1.7.8.jar -S main.rb".
In main.rb I have: fxml_root File.dirname(__FILE__)
What I get is:

Exception running Application:
#<TypeError: can't convert nil into String>
org/jruby/RubyFile.java:1919:in `join'
org/jruby/RubyFile.java:830:in `join'
file:C:/example/jruby-complete-1.7.8.jar!/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:339:in `
get_fxml_loader'

Is there a quick fix I can try to make it work? Thanks.

[byteit101]

@jjgh use the two argument version

fxml_root path_when_not_in_jar, jar_relative_path

ex:

fxml_root File.dirname(__FILE__) "."

[illtellyoulater]

@byteit101 if I do that I get:

Exception running Application:
#<NoMethodError: undefined method `open_stream' for nil:NilClass>
jar:file:C:/example/jruby-complete-1.7.8.jar!/gems/jrubyfx-fxmlloader-0.3-java/lib/jrubyfx-fxmlloade
r.rb:300:in `load'
file:C:/example/jruby-complete-1.7.8.jar!/gems/jrubyfx-1.1.0-java/lib/jrubyfx/controller.rb:117:in `
load_into'
file:C:/example/jruby-complete-1.7.8.jar!/gems/jrubyfx-1.1.0-java/lib/jrubyfx/core_ext/stage.rb:82:i
n `fxml'
main.rb:20:in `start'
file:C:/example/jruby-complete-1.7.8.jar!/gems/jrubyfx-1.1.0-java/lib/jrubyfx/java_fx_impl.rb:125:in
 `launch_app_after_platform'
org/jruby/gen/InterfaceImpl663175377.gen:13:in `run'

Uh... what now :)

[byteit101]

oh ah misread that originally. That's because at the current time, your fxml files must either be inside a jar, or none of the ruby code can be inside a jar because jrubyfx checks to see if it is in a jar path, and if so, tries to load everything relative to the jar