Skip to content

feature-lifecycle #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2014
Merged

feature-lifecycle #20

merged 2 commits into from
Jan 16, 2014

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Jan 16, 2014

@jmdobry
Fixes #19.
079a9d9 
Added lifecycle hooks to DS.save and DS.create. #7
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 079a9d9 on feature-lifecycle into a067045 on 0.5.0.

@jmdobry
Closes #7.
82225b7 
Implemented all lifecycle hooks, including tests.

Cleaned up use of promises in async methods.
@coveralls
Copy link

Coverage Status

Coverage increased (+13.87%) when pulling 82225b7 on feature-lifecycle into a067045 on 0.5.0.

@ghost ghost assigned jmdobry Jan 16, 2014
jmdobry added a commit that referenced this pull request Jan 16, 2014
@jmdobry
Merge pull request #20 from jmdobry/feature-lifecycle
3d3f6f5 
feature-lifecycle
@jmdobry jmdobry merged commit 3d3f6f5 into 0.5.0 Jan 16, 2014
@jmdobry jmdobry deleted the feature-lifecycle branch January 16, 2014 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmdobry jmdobry

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jmdobry @coveralls