Check for instance wherel rule is undefined. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's good to add this check, but I'm wondering why a rule would be undefined. Can you post here your schema definition that's causing the error. Or better yet, and plunker that demonstrates the issue? Here's one you can work from: http://plnkr.co/edit/LV6c0Y?p=info |
|
http://plnkr.co/edit/i8G2JF?p=preview See console for |
|
I'm investigating, I think there's a deeper bug here. |
|
Yes, it turns out there was a deeper issue, requiring a different fix. I still think it's good to add these checks, so I'll merge your PR and then make the other fix. |
jmdobry
added a commit
that referenced
this pull request
Apr 7, 2015
Check for instance wherel rule is undefined.
|
Awesome! Thanks for the quick fixes! |
|
@facultymatt It's actually fixed in 1.2.3. 1.2.2 was missing one tiny piece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that happens when using nested schema.
We check that rule exists AND is not async.
I was not sure how to test this, so no tests are included. I only encountered this issue when using schema with js-data and js-data angular.