Skip to content

Add option to helper functions to render assets inline #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add option to helper functions to render assets inline #306

wants to merge 2 commits into from

Conversation

luckycadow
Copy link

Add an optional argument to css and js helper functions to render contents inline for critical path assets.

@adunkman
Copy link
Collaborator

Just noticed this, sorry for not reviewing sooner!

I’m not a huge fan of boolean arguments, since they are inherently undiscoverable — you need to read the documentation to understand what it means.

What do you think about solving this problem with a separate helper? For examples:

style= asset("critical-path.css")

This would let you use it for other things, too — like embedding SVGs:

div.graph= asset("graph.svg")

@luckycadow
Copy link
Author

I like that. Would you like me to close this merge request and open a new one?

@adunkman
Copy link
Collaborator

Yeah, that’d be great — thanks @luckycadow!

@adunkman adunkman closed this Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants