Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/factory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as sourceMapSupport from 'source-map-support';
sourceMapSupport.install();

import factoryTest from './factoryTest';
import LockedMigrationsError from './utils/errors/LockedMigrationsError';
import ProcessedMigration from './utils/types/ProcessedMigration';

let processedMigrations: ProcessedMigration[] = []; // tslint:disable-line:no-let
Expand All @@ -16,7 +17,7 @@ factoryTest({
},
lockMigrations: async () => {
if (hasLockedMigrations) {
throw new Error();
throw new LockedMigrationsError();
}
hasLockedMigrations = true;
},
Expand Down
7 changes: 7 additions & 0 deletions src/migrate/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'mocha'; // tslint:disable-line:no-import-side-effect
import factory from '../factory';
import RepoFacade from '../RepoFacade';
import FailingMigrationError from '../utils/errors/FailingMigrationError';
import LockedMigrationsError from '../utils/errors/LockedMigrationsError';
import createMigrationProcess from '../utils/tests/createMigrationProcess';
import createTestUpMigration from '../utils/tests/createTestUpMigration';
import MigrationDictionary from '../utils/types/MigrationDictionary';
Expand Down Expand Up @@ -71,5 +72,11 @@ export default (repo: RepoFacade) => {
assert.equal(skippedMigration.getProcessed(), false);
assert.equal(unskippedMigration.getProcessed(), true);
});

it('should error when migrations are locked', async () => {
const service = createService({});
const promise = Promise.all([service.migrate(), service.migrate()]);
await assertRejects(promise, LockedMigrationsError);
});
});
};
11 changes: 11 additions & 0 deletions src/migrateByKey/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ import 'mocha'; // tslint:disable-line:no-import-side-effect
import factory from '../factory';
import RepoFacade from '../RepoFacade';
import FailingMigrationError from '../utils/errors/FailingMigrationError';
import LockedMigrationsError from '../utils/errors/LockedMigrationsError';
import MissingMigrationError from '../utils/errors/MissingMigrationError';
import ProcessedMigrationError from '../utils/errors/ProcessedMigrationError';
import createMigrationProcess from '../utils/tests/createMigrationProcess';
import createTestUpMigration from '../utils/tests/createTestUpMigration';
import MigrationDictionary from '../utils/types/MigrationDictionary';

export default (repo: RepoFacade) => {
const successfulMigration = createTestUpMigration();
const failingMigration = createTestUpMigration(() => { throw new Error(); });

const createService = (migrations: MigrationDictionary) => {
Expand Down Expand Up @@ -54,5 +56,14 @@ export default (repo: RepoFacade) => {
await service.migrateByKey({ key: 'testMigration', force: true });
assert.equal(getProcessed(), true);
});

it('should error when migrations are locked', async () => {
const service = createService({ successfulMigration });
const promise = Promise.all([
service.migrateByKey({ key: 'successfulMigration' }),
service.migrateByKey({ key: 'successfulMigration' }),
]);
await assertRejects(promise, LockedMigrationsError);
});
});
};
7 changes: 7 additions & 0 deletions src/rollback/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'mocha'; // tslint:disable-line:no-import-side-effect
import factory from '../factory';
import RepoFacade from '../RepoFacade';
import FailingMigrationError from '../utils/errors/FailingMigrationError';
import LockedMigrationsError from '../utils/errors/LockedMigrationsError';
import MissingMigrationError from '../utils/errors/MissingMigrationError';
import createMigrationProcess from '../utils/tests/createMigrationProcess';
import createTestDownMigration from '../utils/tests/createTestDownMigration';
Expand Down Expand Up @@ -83,5 +84,11 @@ export default (repo: RepoFacade) => {
assert.equal(skippedMigration.getProcessed(), false);
assert.equal(unskippedMigration.getProcessed(), true);
});

it('should error when migrations are locked', async () => {
const service = createService({});
const promise = Promise.all([service.rollback(), service.rollback()]);
await assertRejects(promise, LockedMigrationsError);
});
});
};
12 changes: 12 additions & 0 deletions src/rollbackByKey/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ import 'mocha'; // tslint:disable-line:no-import-side-effect
import factory from '../factory';
import RepoFacade from '../RepoFacade';
import FailingMigrationError from '../utils/errors/FailingMigrationError';
import LockedMigrationsError from '../utils/errors/LockedMigrationsError';
import UnprocessedMigrationError from '../utils/errors/UnprocessedMigrationError';
import createMigrationProcess from '../utils/tests/createMigrationProcess';
import createTestDownMigration from '../utils/tests/createTestDownMigration';
import MigrationDictionary from '../utils/types/MigrationDictionary';

export default (repo: RepoFacade) => {
const successfulMigration = createTestDownMigration();
const failingMigration = createTestDownMigration(() => { throw new Error(); });

const createService = (migrations: MigrationDictionary) => {
Expand Down Expand Up @@ -53,5 +55,15 @@ export default (repo: RepoFacade) => {
await service.rollbackByKey({ key: 'testMigration', force: true });
assert.equal(getProcessed(), true);
});

it('should error when migrations are locked', async () => {
const service = createService({ successfulMigration });
await service.migrate();
const promise = Promise.all([
service.rollbackByKey({ key: 'successfulMigration' }),
service.rollbackByKey({ key: 'successfulMigration' }),
]);
await assertRejects(promise, LockedMigrationsError);
});
});
};
8 changes: 8 additions & 0 deletions src/utils/errors/LockedMigrationsError.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// tslint:disable:no-class
import { BaseError } from 'make-error';

export default class LockedMigrationsError extends BaseError {
constructor() {
super();
}
}