lvp.js.org #3767
Merged
lvp.js.org #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luzhenqian
commented
Mar 2, 2020
luzhenqian
commented
- [√] There is reasonable content on the page (see: No Content)
- [√] I have read and accepted the Terms and Conditions
MattIPv4
requested changes
Mar 2, 2020
There was a problem hiding this comment.
Hi there!
Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance lvp.js.org.
MattIPv4
added
the
awaiting custom domain
|
Thanks for the reminder, it has been added. |
MattIPv4
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
✅ Commit valid, CNAME present, site appears to have content *
* based off https://github.com/luzhenqian/lvp.js/tree/master/docs
MattIPv4
added
add
|
Welcome https://lvp.js.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.