Skip to content

http4ts.js.org #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2020
Merged

http4ts.js.org #3786

merged 1 commit into from
Mar 8, 2020

Conversation

alisabzevari
Copy link
Contributor

Add http4ts.

MattIPv4
MattIPv4 requested changes Mar 7, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance http4ts.js.org.

@MattIPv4 MattIPv4 added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Mar 7, 2020
@MattIPv4 MattIPv4 changed the title Add http4ts http4ts.js.org Mar 7, 2020
@alisabzevari
Copy link
Contributor Author

Hi,

Thank you for mentioning this. I forgot to deploy the changes. It is there now.

MattIPv4
MattIPv4 approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/http4ts/http4ts/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Mar 7, 2020
@indus
Copy link
Member

indus commented Mar 8, 2020

Welcome https://http4ts.js.org

@indus
Copy link
Member

indus commented Mar 8, 2020

Looks like some assets paths are wrong now.

@indus indus merged commit e883c4c into js-org:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisabzevari @indus @MattIPv4