Skip to content

Conversation

GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Apr 1, 2020

Adds URLs for open source project <my-app />

Details:

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split each request into its own PR :)

@GirlBossRush GirlBossRush changed the title my-app.js.org & my-server.js.org my-app.js.org Apr 2, 2020
@GirlBossRush GirlBossRush requested a review from MattIPv4 April 2, 2020 19:53
@GirlBossRush
Copy link
Contributor Author

@MattIPv4,

Thanks much!

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/nirrius/my-app/tree/master/docs

@MattIPv4
Copy link
Member

MattIPv4 commented Apr 2, 2020

FYI, all your links in the examplar code are local file links, which won't work for everyone else: https://github.com/nirrius/my-app/blob/master/docs/index.html#L32

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed invalid labels Apr 2, 2020
@GirlBossRush
Copy link
Contributor Author

@MattIPv4 thanks for the heads up! Seems my markdown parser is adding in blank anchor tags for clickable line markers. I can continue polishing this week. Is there anything else needed to merge?

@MattIPv4
Copy link
Member

MattIPv4 commented Apr 2, 2020

👍 This is good to go, you'll just need to wait for Stefan to merge this in the morning

@indus
Copy link
Member

indus commented Apr 3, 2020

Welcome https://my-app.js.org

@indus indus merged commit 2f00380 into js-org:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants