Skip to content

Conversation

midzdotdev
Copy link
Contributor

This static VuePress site will hold the documentation for my web scraper project which is currently being developed. I'm aware there's not very much content however, this will not be abandoned as I am using it for my Final Year Project (thesis) at University.

This static VuePress site will hold the documentation for my web scraper project which is currently being developed. I'm aware there's not very much content however, this will not be abandoned as I am using it for my Final Year Project (thesis) at University.
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://spider-scraper.netlify.app/

I trust that your netlify is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Apr 4, 2020
@MattIPv4 MattIPv4 changed the title Add spider.js.org spider.js.org Apr 4, 2020
@indus indus added the 404 The page requested returns a 404 response label Apr 4, 2020
@indus
Copy link
Member

indus commented Apr 4, 2020

I've already added your requested subdomain to JS.ORGs zonefile. But the host returns a "Not found". Maybe you have to configure the custom domain there as well?!?
I'll merge after we have "contact".

@midzdotdev
Copy link
Contributor Author

Apologies, I forgot to add it as a custom domain in Netlify.

Sorted now!

@indus indus removed the 404 The page requested returns a 404 response label Apr 5, 2020
@indus
Copy link
Member

indus commented Apr 5, 2020

Welcome https://spider.js.org

@indus indus merged commit e988cf6 into js-org:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants