Skip to content

Conversation

pranshuchittora
Copy link
Contributor

Description
Adding pranshuchittora.github.io 🤓
Thanks 🤩

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance pranshuchittora.js.org.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain user This PR/issue is regarding a target on a GitHub user account labels Apr 6, 2020
@MattIPv4 MattIPv4 changed the title Adding pranshuchittora.js.org pranshuchittora.js.org Apr 6, 2020
@pranshuchittora
Copy link
Contributor Author

@indus
Copy link
Member

indus commented Apr 7, 2020

You can only use the "master", "gh-pages" or "docs" branch for GithubPages. FYI: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages
So you will have to move the CNAME to one of these branches or use the repo settings to do so.

@pranshuchittora
Copy link
Contributor Author

You can only use the "master", "gh-pages" or "docs" branch for GithubPages. FYI: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages
So you will have to move the CNAME to one of these branches or use the repo settings to do so.

Oh, I didn't know that. I did the following changes :)
BTW, Thanks for the info.

@MattIPv4
Copy link
Member

MattIPv4 commented Apr 7, 2020

You appear to have added it here: https://github.com/pranshuchittora/pranshuchittora.github.io/blob/master/CNAME

But that branch doesn't contain your website? Shouldn't it be in the static folder, so that it'll get built to the root of the gh-pages branch, which is where your site is?

@pranshuchittora
Copy link
Contributor Author

Pardon, just made the following changes.
https://github.com/pranshuchittora/pranshuchittora.github.io/blob/gh-pages/CNAME
I am serving the site through gh-pages branch. The CNAME file can be accessed via the link provided above. :)

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/pranshuchittora/pranshuchittora.github.io/tree/gh-pages

@MattIPv4 MattIPv4 removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Apr 7, 2020
@indus
Copy link
Member

indus commented Apr 7, 2020

Welcome https://pranshuchittora.js.org

@indus indus merged commit da3d3fe into js-org:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants