Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envshh.js.org #8518

Merged
merged 1 commit into from
Sep 17, 2023
Merged

envshh.js.org #8518

merged 1 commit into from
Sep 17, 2023

Conversation

sanjib-sen
Copy link
Contributor

@sanjib-sen sanjib-sen changed the title added envshh envshh.js.org Sep 16, 2023
MattIPv4
MattIPv4 requested changes Sep 16, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 16, 2023
@sanjib-sen
Copy link
Contributor Author

@MattIPv4 Sorry for the inconvenience. Just did so.

@indus indus added error The page requested returns an error and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 16, 2023
@indus
Copy link
Member

indus commented Sep 16, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@sanjib-sen
Copy link
Contributor Author

@indus thanks. working on this.

@sanjib-sen
Copy link
Contributor Author

sanjib-sen commented Sep 16, 2023 •
edited
Loading

@indus Hi. Can you please check now? I used the default pages deployment action

@indus indus added awaiting response This PR is waiting for a response from the requester no content This PR has a target that contains no valid content for a request and removed error The page requested returns an error labels Sep 16, 2023
@indus
Copy link
Member

indus commented Sep 16, 2023

@sanjib-sen The page is no working. but I wonder what the content is. This looks exactly like: https://stackblitz.com/github/withastro/starlight/tree/main/examples/basics?file=README.md
Please give me an idea what the you page is about.

@indus
Copy link
Member

indus commented Sep 16, 2023 •
edited
Loading

As stated in the readme I'm not accepting requests for pages without content.

@indus indus closed this Sep 16, 2023
@indus indus reopened this Sep 16, 2023
@sanjib-sen
Copy link
Contributor Author

@indus Sorry for the inconvenience.
I guess the issue was happening because my baseUrl was different.
Now I fixed it and the page should be visible now.

I also deployed it to vercel so that you can check the contents.
https://envshh.vercel.app/

@indus
Copy link
Member

indus commented Sep 16, 2023 •
edited
Loading

You can check for your self here: https://envshh.js.org
I already thought that this is not your actual content but the readme in your repo. There is still something wrong in your setup. Your repo is quite confusing to me. You have:

  • a master branch
  • a docs folder in the master branch
  • a gh-pages branch
  • a docs folder in the gh-pages branch
  • and a workflow

any of those could be the location of your page. Putting the CNAME in the root of your master branch makes this to the root of your GitHub Page and uses the readme.md as index.html. You have to change this to show your actual page.
There is some info about using other locations as the root for your page: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages. But I guess your are trying to use a workflow?! It is hard for me to give you support with that.

@indus
Copy link
Member

indus commented Sep 16, 2023

Maybe the setting mentioned in this PR is helpful: #8294 (comment)

@sanjib-sen
Copy link
Contributor Author

Oh sorry for putting the CNAME file in the root folder before.
My site is in the master branch and inside the docs directory.

I removed the CNAME file from the root and the gh-pages branch.

I am still seeing 302 Status error on the envshh.js.org page after deleting those.
I do not know what is causing the issue. I tried removing the custom domain from the GitHub pages settings, and it is still redirecting me to envshh.js.org as changing domains can take up to 24 hours to be visible.

Can You merge this so that I can check if the error persists or not? Don't worry, you can remove the site later if you want. Or I will probably wait some hours to get the GitHub DNS change fixed.

@MattIPv4
Copy link
Member

The site appears to be working for me now 👍

@sanjib-sen
Copy link
Contributor Author

sanjib-sen commented Sep 16, 2023 •
edited
Loading

The site appears to be working for me now 👍

@MattIPv4 Yeah but I am getting 302 Redirect error on envshh.js.org

@MattIPv4
Copy link
Member

I think that is probably your browser caching the page...

curl -i https://envshh.js.org

HTTP/2 200 
...

<!DOCTYPE html><html lang="en" dir="ltr" data-has-hero class="astro-nyfq2let"><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1"/><title>envshh - .envs made easy</title>
...

@sanjib-sen
Copy link
Contributor Author

Checked again. Working for me now too.
Thanks!!!
@MattIPv4 @indus

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account and removed no content This PR has a target that contains no valid content for a request awaiting response This PR is waiting for a response from the requester labels Sep 16, 2023
@MattIPv4 MattIPv4 added the project This PR has a target of a project on an organisation or user account label Sep 16, 2023
@indus
Copy link
Member

indus commented Sep 17, 2023

Welcome https://envshh.js.org

@indus indus merged commit f30961e into js-org:master Sep 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 Awaiting requested review from MattIPv4

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjib-sen @indus @MattIPv4