Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed weighted average (#21) #22

Merged
merged 2 commits into from
Jan 17, 2017
Merged

Fixed weighted average (#21) #22

merged 2 commits into from
Jan 17, 2017

Conversation

RickCardoso
Copy link
Contributor

@RickCardoso RickCardoso commented Jan 15, 2017 •
edited by eduardomourar
Loading

See #21 for details. Now the completion of a task is the average of its subtasks weighted by
the duration of each one.

@RickCardoso
Fixed weighted average.
3a607b7 
Now the completion of a task is the average of its subtasks weighted by
the duration of each one.
@eduardomourar eduardomourar changed the title Fixed weighted average. Fixed weighted average (#21) Jan 15, 2017
@eduardomourar eduardomourar requested review from eduardomourar and removed request for eduardomourar January 15, 2017 17:50
@eduardomourar
Copy link
Collaborator

Rick, thanks for the changes. I have reviewed and it is good. Please, add this change to the first lines for me to merge:

/*
	   _        ___            _   _    _____                                        _ 
	  (_)___   / _ \__ _ _ __ | |_| |_  \_   \_ __ ___  _ __  _ __ _____   _____  __| |
	  | / __| / /_\/ _` | '_ \| __| __|  / /\/ '_ ` _ \| '_ \| '__/ _ \ \ / / _ \/ _` |
	  | \__ \/ /_\\ (_| | | | | |_| |_/\/ /_ | | | | | | |_) | | | (_) \ V /  __/ (_| |
	 _/ |___/\____/\__,_|_| |_|\__|\__\____/ |_| |_| |_| .__/|_|  \___/ \_/ \___|\__,_|
	|__/                                               |_|                             
	jsGanttImproved 1.7.5.3

Adding a new version and avoiding having to change the ASCII art every time.

@RickCardoso
Fixed weighted average (#21)
18e6ffc 
Now the completion of a task is the average of its subtasks weighted by the duration of each one.

In addition to changing the logo as requested, the NumKid property was kept and the vWeight parameter was added to be used for the weighted average.
@eduardomourar eduardomourar merged commit e5583ed into jsGanttImproved:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickCardoso @eduardomourar