possible to specify options via data- attributes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,14 +25,21 @@ | |||
| if (!attrs.length) return data; | |||
|
|
|||
| $.each(attrs, function (i, attr) { | |||
| if (/^data-in-*/.test(attr.nodeName)) { | |||
|
|
|||
| function stringToBoolean(str) { | |||
There was a problem hiding this comment.
I would be better to move stringToBoolean to the top level scope (the same as isInEffect/isOutEffect ) so it isn't being continuously redefined.
There was a problem hiding this comment.
IMHO, in modern browsers, the function will only be parsed once. Being repeatedly redefined does not incur additional load on the JavaScript engine. This MDN document mentioned about it at around 3/5 down the article. I wrote it this way as it seemed neater, as in the getData function can be self-contained.
|
Thanks for this, just a couple minor comments but looks good! |
|
Hi, I explained my reasoning behind some of the changes. Kindly refer to the line notes. |
jschr
pushed a commit
that referenced
this pull request
Jul 28, 2014
possible to specify options via data- attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it seems that jquery.find returns an array instead of a single element. This prevented textillate from reading the options specified in the
This patch fixes that error. Also, it converts "true"/"false" to true/false in the case of data-in-shuffle etc., and handles situation where data-in-delayScale is forcibly changed to lower case. This makes it possible to specify those options as well.