This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
Couple updates #50
Merged
Couple updates #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise jscs module for text editors would not pick it up
| @@ -10,6 +10,9 @@ module.exports = function( grunt ) { | |||
| grunt.registerMultiTask( "jscs", "JavaScript Code Style checker", function() { | |||
| var done = this.async(), | |||
| options = this.options({ | |||
|
|
|||
| // null is a default value, but its equivalent to `true`, | |||
| // with this way it's easy to distinguish specified value | |||
There was a problem hiding this comment.
trailing whitespace in this line
There was a problem hiding this comment.
Rebased.
Funny, a lot of things lead to that issue, like: didn't do proper npm i, didn't correctly set settings in new editor, should have checked travis run a bit after i send a PR and of course - shouldn't had high hopes for Russia vs Belgium match :((
There was a problem hiding this comment.
I bet you'll win against Algeria :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests, comments and minor improvements. Only one noticeable thing, i suppose, is a change in the README for
configoption, in order to remove confusion like this.