feat: extra TLS data #210
Merged
feat: extra TLS data #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -391,6 +401,11 @@ export class HttpCommand implements CommandInterface<HttpOptions> { | |||
| ...cert.subject, | |||
| alt: cert.subjectaltname, | |||
| }, | |||
| serialNumber: cert.serialNumber.match(/.{2}/g)!.join(':'), | |||
| fingerprint256: cert.fingerprint256, | |||
| keyType: cert.asn1Curve || cert.nistCurve ? 'EC' : cert.modulus || cert.exponent ? 'RSA' : null, | |||
There was a problem hiding this comment.
@alexey-yarmosh just fyi, getX509Certificate() is indeed for server certificates, but there's also getPeerX509Certificate() which does work for our case. But it returns some other fields in a form that we would have to additionally parse, so I decided to keep your approach. RSA and EC are the only two types we should encounter on the web so it should be fine.
|
I removed sha1 and sha512 fingerprints as they all do the same thing, and:
We can add later if needed, but just one of these should be enough. On the other hand, I added the certificate fingerprint and key size fields. |
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of jsdelivr/globalping#500