[[FIX]] Tolerate keyword in object shorthand

Ensure that JSHint reports a syntax error rather than crashing.
jshint · Sep 23, 2021 · 057b1c6 · 057b1c6
1 parent ecae54a
commit 057b1c6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/jshint.js b/src/jshint.js
@@ -4075,8 +4075,10 @@ var JSHINT = (function() {
             warning("W104", state.tokens.next, "object short notation", "6");
           }
           t = expression(context, 10);
-          i = t.value;
-          saveProperty(props, i, t);
+          i = t && t.value;
+          if (t) {
+            saveProperty(props, i, t);
+          }
 
         } else if (peek().id !== ":" && (nextVal === "get" || nextVal === "set")) {
           advance(nextVal);

diff --git a/tests/unit/parser.js b/tests/unit/parser.js
@@ -10647,3 +10647,21 @@ exports.loneNullishCoalescing = function (test) {
 
   test.done();
 };
+
+// gh-3571: "Cannot read properties of undefined at Object.e.nud"
+exports.keywordAsShorthandObjectProperty = function (test) {
+  TestRun(test, "as reported")
+    .addError(1, 12, "Expected an identifier and instead saw 'do'.")
+    .addError(1, 15, "Missing semicolon.")
+    .test("const a = {do}", {esversion: 6});
+
+  TestRun(test, "simplified")
+    .addError(1, 7, "Expected an identifier and instead saw 'do'.")
+    .test("void {do};", {esversion: 6});
+
+  TestRun(test, "alternate - penultimate member")
+    .addError(1, 7, "Expected an identifier and instead saw 'for'.")
+    .test("void {for, baz};", {esversion: 6});
+
+  test.done();
+};