add missing dirs into install command #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
reviewed
Jun 19, 2018
jsk_tilt_laser/CMakeLists.txt
Outdated
| @@ -50,3 +50,11 @@ if(NOT APPLE) | |||
| RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION} | |||
| ) | |||
| endif(NOT APPLE) | |||
|
|
|||
| install(DIRECTORY scripts | |||
| DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION} | |||
There was a problem hiding this comment.
may be you can put this directory under CATKIN_PACKAGE_SHARE_DESTINATION
move scripts dir into SHARE
k-okada
reviewed
Jun 20, 2018
| @@ -50,3 +50,7 @@ if(NOT APPLE) | |||
| RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION} | |||
| ) | |||
| endif(NOT APPLE) | |||
|
|
|||
| install(DIRECTORY launch config cfg scripts | |||
| DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION} | |||
There was a problem hiding this comment.
please add USE_SOURCE_PERMISSIONS
There was a problem hiding this comment.
fixed as you said now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.