Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use xdg-open for ubuntu16.04 and above #1638

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

knorth55
Copy link
Member

gnome-open is removed in ubuntu 16.04 and above.
we need to use xdg-open instead.

@wkentaro
Copy link
Member

wkentaro commented Oct 20, 2019

Really. You mean it's not been installed by default anymore?
Screen Shot 2019-10-20 at 01 45 03

@wkentaro
Copy link
Member

Maybe you can check existence like the following?
Screen Shot 2019-10-20 at 01 47 29

@knorth55
Copy link
Member Author

gnome-open is remove in ubuntu 18.04 and xdg-open is used for default.
in ubuntu 16.04, you can use both probably, but my computer doesn't have gnome-open.
I have no idea that pure ubuntu 16.04 has both by default or not.

@wkentaro
Copy link
Member

wkentaro commented Oct 20, 2019 via email

@knorth55
Copy link
Member Author

so it is better to use xdg-open in ubuntu 16.04 and above?

@wkentaro
Copy link
Member

My suggestion is here: #1638 (comment)
You can check xdg-open before gnome-open if you like.

@k-okada
Copy link
Member

k-okada commented Oct 21, 2019 via email

@wkentaro
Copy link
Member

wkentaro commented Oct 21, 2019

It seems xdg-open is installed by default. and gnome-open is not. (I checked on my computers not dockers)

@knorth55
Copy link
Member Author

knorth55 commented Nov 2, 2019

I update to check if xdg-open is installed and use xdg-open if it is installed and use gnome-open if xdg-open is not installed.

Copy link
Member

@wkentaro wkentaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform is unused?

@knorth55
Copy link
Member Author

knorth55 commented Nov 2, 2019

do we need platform check?

@wkentaro
Copy link
Member

wkentaro commented Nov 2, 2019

Ah, I mean you import, but never use it.

@knorth55
Copy link
Member Author

knorth55 commented Nov 3, 2019

I updated

@k-okada k-okada merged commit d3d35a9 into jsk-ros-pkg:master Jul 10, 2020
@knorth55 knorth55 deleted the fix-jsk-data branch July 10, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants