Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[euscollada/pr2.sh] check the existence of /etc/ros/distro/urdf/robot.xml for PR2 #120

Closed
wants to merge 1 commit into from

Conversation

aginika
Copy link

@aginika aginika commented Jun 22, 2015

@k-okada
Is this the function which will convert the calibrated files to pr2.l which you told me today?

I added the line to check the existence of /etc/ros/distro/urdf/robot.xml which must be in PR2 robot inside.

@aginika aginika changed the title [euscollada] check the existence of /etc/ros/distro/urdf/robot.xml [euscollada/pr2.sh] check the existence of /etc/ros/distro/urdf/robot.xml for PR2 Jun 22, 2015
@k-okada
Copy link
Member

k-okada commented Jun 22, 2015

No, https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus/make-pr2-model-file.l

Using robot.xml is good idea but we did not use that because you have to login to robot machine to do jobs

◉ Kei Okada

2015/06/22 21:56、Yuto Inagaki notifications@github.com のメッセージ:

@k-okada
Is this the function which will convert the calibrated files to pr2.l which you told me today?

I added the line to check the existence of /etc/ros/distro/urdf/robot.xml which must be in PR2 robot inside.

You can view, comment on, or merge this pull request online at:

#120

Commit Summary

[euscollada] check the exist of /etc/ros/distro/urdf/robot.xml
File Changes

M euscollada/pr2.sh (8)
Patch Links:

https://github.com/jsk-ros-pkg/jsk_model_tools/pull/120.patch
https://github.com/jsk-ros-pkg/jsk_model_tools/pull/120.diff

Reply to this email directly or view it on GitHub.

@aginika
Copy link
Author

aginika commented Jun 22, 2015

Oh thanks , I will use that

@aginika aginika closed this Jun 22, 2015
aginika pushed a commit to aginika/jsk_model_tools that referenced this pull request Jul 30, 2015
add jsk_peper_robot (add CMakeLists.txt launch/jsk_pepper_startup.launch package.xml tweet.l)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants