Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there way to change dynamic parameter with timestamp? #1444

Open
wkentaro opened this issue Dec 20, 2015 · 6 comments
Open

Is there way to change dynamic parameter with timestamp? #1444

wkentaro opened this issue Dec 20, 2015 · 6 comments
Labels

Comments

@wkentaro
Copy link
Member

I'd like to use dynamic_reconfigure for recognition with timestamp.
Currently, the config callback does not see the timestamp https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_pcl_ros/src/organized_multi_plane_segmentation_nodelet.cpp#L172
and dynamic_reconfigure seems to be not designed to do so.

Any idea to fix this issue?
I think there are two solutions:

  1. Change the configCallback to make the node to see the timestamp.
  2. Change dynamic_reconfigure to serve another topic with timstamp (like dynamic_reconfigure/ReconfigureStamped). (currently, dynamic_reconfigure serves set_parameters service not topic)
@wkentaro
Copy link
Member Author

The first option may break current system and the nodes' behavior will change, so I think it's not good idea.

@wkentaro
Copy link
Member Author

Could you please give me some advice? @garaemon @k-okada

@garaemon
Copy link
Member

It depends on your purpose.

Whey you need timestamp on dynamic_reconfigure?

@wkentaro
Copy link
Member Author

It depends on your purpose.

Yes, so I don't want to break current system.

Whey you need timestamp on dynamic_reconfigure?

To change the parameter from now (the time I changed the parameter), not the time the configCallback is called in each recognition node.

@garaemon
Copy link
Member

To change the parameter from now (the time I changed the parameter), not the time the configCallback is called in each recognition node.

hmm, it sounds difficult.
Your problem is latency between rqt_dynamic_reconfigure event callback and service call?

@wkentaro
Copy link
Member Author

Your problem is latency between rqt_dynamic_reconfigure event callback and service call?

Maybe no, the problem is a node cannot know that what data with what timestamp other node processing.

What I want to do is to specify the timestamp and parameter for a processing, this can be significant in dynamic environment.
At this time, I'm in not so dynamic environment so maybe current dynamic reconfigure system does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants